Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Some improvements (part 2) #18

Closed
3 tasks done
jstoiko opened this issue Oct 17, 2017 · 1 comment
Closed
3 tasks done

Some improvements (part 2) #18

jstoiko opened this issue Oct 17, 2017 · 1 comment
Milestone

Comments

@jstoiko
Copy link
Contributor

jstoiko commented Oct 17, 2017

JSON Schema->RAML DT:

  • make output less verbose
    • remove required: true (RAML defaults to true)
    • replace required: false by <property>? [1]
    • for properties that only have a {"type" : <type>} defined in JSON schema, write it in the form <propertyName>: <type> in RAML

RAML DT->JSON Schema:

  • convert RAML pattern properties (here search for This pattern property) to JSON object.patternProperties
  • support for external includes

--
[1] see RAML 1.0 Property Declaration

@jstoiko jstoiko mentioned this issue Oct 17, 2017
7 tasks
@jstoiko jstoiko added this to the v0.1.2 milestone Dec 13, 2017
@brevity
Copy link
Contributor

brevity commented Dec 20, 2017

@jstoiko,
For the second item, 'type string with media wasn't necessarily a RAML type file before'.

What sort of state in the JSON Schema are we trying to account for. Currently, js2dt() identifies a file if data.type is a string, and data.media.binaryEncoding = 'binary' Is this issue raised when converting from raml->js and back again?

@jstoiko jstoiko modified the milestones: v0.1.2, v0.2.0 Dec 22, 2017
@jstoiko jstoiko modified the milestones: v0.2.0, v0.1.3 Feb 27, 2018
@jstoiko jstoiko closed this as completed Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants