Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for is_inline on databases #138

Closed
weallwegot opened this issue Jul 19, 2022 · 2 comments
Closed

Support for is_inline on databases #138

weallwegot opened this issue Jul 19, 2022 · 2 comments
Labels
task Something that has to be done at some point

Comments

@weallwegot
Copy link

Hi, I think they recently added support for is_inline on databases. Not sure if I understand the sdk well but would the update be at this line to just include a new argument in the pick function?

changelog announcing new support

notion-sdk-py/notion_client/api_endpoints.py

Line 156 in 6b0fb3e

body=pick(kwargs, "parent", "title", "properties", "icon", "cover"),

@ramnes
Copy link
Owner

ramnes commented Jul 20, 2022

Yes, that's it!

We are lagging a bit behind notion-sdk-js and I think there are a few pick arguments to add, not just is_inline. :)

@ramnes ramnes added the task Something that has to be done at some point label Jul 20, 2022
@ramnes
Copy link
Owner

ramnes commented Oct 26, 2022

Closed with #154

@ramnes ramnes closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Something that has to be done at some point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramnes @weallwegot