Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hints to Response and Arguments of a function #231

Closed
JVGC opened this issue Jan 27, 2024 · 1 comment
Closed

Add Type Hints to Response and Arguments of a function #231

JVGC opened this issue Jan 27, 2024 · 1 comment

Comments

@JVGC
Copy link

JVGC commented Jan 27, 2024

I just started using the package, and one thing I notice is that it's missing type hints for what the function should expect as arguments and what it actually returns.

I would say that adding that would be a really useful thing, specially because would allow me to only look for the notion api documents in special cases.

@ramnes
Copy link
Owner

ramnes commented Jan 30, 2024

Closing in favor of #199. Some work has been done in #200 and this branch, feel free to work on top of these if you want to contribute and maintain these types. Thanks!

@ramnes ramnes closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants