Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GeoAPI off Dojo #173

Closed
james-rae opened this issue Aug 6, 2020 · 1 comment
Closed

Migrate GeoAPI off Dojo #173

james-rae opened this issue Aug 6, 2020 · 1 comment
Assignees
Labels
effort: far away Will take a respectable amount of work flavour: enhancement Improving something existing priority: nice Would be excellent if this got done

Comments

@james-rae
Copy link
Member

Once the ESRI API is finished migrating off of Dojo (likely v4.17), attempt the following.

  • Rip out all the Dojo loading stuff.
  • Use the ESRI API that will be published on npm as a project dependency.
  • Convert all uses of EsriBundle to now just import classes from the npm library
  • Move the GeoAPI code inside the ramp-core package. This will improve:
    • ease of using types and interfaces in the core
    • will vastly improve the ability to step through GeoAPI code when debugging
    • can hot-reload when changing GeoAPI code
@james-rae james-rae added effort: far away Will take a respectable amount of work flavour: enhancement Improving something existing priority: nice Would be excellent if this got done type: adaptive labels Aug 6, 2020
@james-rae james-rae self-assigned this Aug 6, 2020
@james-rae
Copy link
Member Author

Another consideration: if GeoAPI is moved inside the ramp-core package, we can investigate ways of leveraging the RAMP event bus and thus getting rid of the GeoAPI event system (though it is pretty amazing).

This is a bit of a trick, as the GeoAPI exists as a stand alone entity, and the RAMP event bus exists on RAMP Instances. So possibly we need to register RAMP Instances with GeoAPI so it can pepper events to all valid instances. Alternately we can entertain spinning up a GeoAPI for each instance; since we would no longer be doing a Dojo load, the performance hit is more in memory space.

TBD....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: far away Will take a respectable amount of work flavour: enhancement Improving something existing priority: nice Would be excellent if this got done
Projects
None yet
Development

No branches or pull requests

1 participant