New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgcheck results - develop #39

Open

github-actions bot opened this issue Aug 17, 2022 · 2 comments

github-actions bot commented Aug 17, 2022

Checks for snomedizer (v0.4.0)

git hash: d55a0283

✔️ Package name is available
✔️ has a 'codemeta.json' file.
✔️ has a 'contributing' file.
✔️ uses 'roxygen2'.
✔️ 'DESCRIPTION' has a URL field.
✔️ 'DESCRIPTION' has a BugReports field.
✔️ Package has at least one HTML vignette
✔️ All functions have examples.
✔️ Package has continuous integration checks.
✖️ Package coverage failed
✖️ R CMD check found 1 error.
✔️ R CMD check found no warnings.

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE

Author

github-actions bot commented Aug 19, 2022

Checks for snomedizer (v0.4.0)

git hash: a1b328c2

✔️ Package name is available
✔️ has a 'codemeta.json' file.
✔️ has a 'contributing' file.
✔️ uses 'roxygen2'.
✔️ 'DESCRIPTION' has a URL field.
✔️ 'DESCRIPTION' has a BugReports field.
✔️ Package has at least one HTML vignette
✔️ All functions have examples.
✔️ Package has continuous integration checks.
✖️ Package coverage failed
✖️ R CMD check found 1 error.
✔️ R CMD check found no warnings.

Important: All failing checks above must be addressed prior to proceeding

Package License: MIT + file LICENSE

Contributor

peterdutey commented Aug 19, 2022 •

edited by AnikaC-git

I read through the report and here are some comments

replacement of sapply by vapply: OK makes plenty of sense
Omit "Date" in DESCRIPTION - I prefer to actually keep it for now. I find it useful. Peer review can ask us to change that later
test.utils.R:11:3 is failing in pkgcheck. We can add the dutch server to the list so it not longer fails
package coverage failing: this has to do with covr and I suspect we need to provide some kind of environment variable or API token to the pkgcheck yaml. It's working fine on the other pipeline so it's probably just a config issue.

Happy to discuss and split the work!
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment