-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return type of Ramsey\Uuid\Uuid::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize() #439
Comments
This is the same issue as #399 and requires a change to the interface, which I can’t do in minor- or patch-level releases when following semver. |
So what is the approach then? For now I created a file in my repository and used it instead, tests pass, but better could be new major version
|
That sounds like a good approach. I’m working on version 5 that will solve this problem, since I can do BC breaks then. |
@ramsey can't you add this for now to surpass the deprecation warning in minor version? > |
Yep. Looks like we can add the |
jsonSerialize returns :string now and so there's no problem at 4.x. You wish to release 3.9.x with a fix ? |
3.9.x still supports PHP 5.4 and 7.x. What change could we make to |
@ramsey is there any timeline for a v5 release? |
This bug is fixed in version 3.9.7. |
Legend. Cheers. |
I have error:
|
Deprecation Issue in PHP8.1
Description
Deprecated: Return type of Ramsey\Uuid\Uuid::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /wayfair/data/www/composer-packages/ramsey/uuid/src/Uuid.php on line 216
PHP Deprecated: PHPUnit\Runner\DefaultTestResultCache implements the Serializable interface, which is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in /wayfair/data/www/composer-packages/phpunit/phpunit/src/Runner/DefaultTestResultCache.php on line 34
Screenshots or output
Environment details
Additional context
The text was updated successfully, but these errors were encountered: