Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the interpretation of variables in the configuration file redis-data-cache.properties #48

Closed
lepapareil opened this issue Feb 3, 2020 · 4 comments

Comments

@lepapareil
Copy link

Hi,

Thanks for this plugin that works perfectly :)

So I have a suggestion, just like the other tomcat conf files, it would be nice to be able to use java variables passed at tomcat startup to make dynamic the REDIS_PORT or REDIS_SERVER information, so in a docker context, the conf file would look like this

redis.hosts=${REDIS_SERVER}:${REDIS_PORT}

and deployment would be given the right value depending on the environment.
Currently I have to have a script that does sed before starting the tomcat :(

thanks :)

@ran-jit
Copy link
Owner

ran-jit commented Feb 5, 2020

Hi @lepapareil,

Thank you very much for your suggestion.

Now we can use the system environment variable as direct values.

redis-data-cache.properties

  1. redis.hosts=${REDIS_HOST}:${REDIS_PORT}
  2. redis.cluster.enabled=${REDIS_CLUSTER_ENABLED}

Changes: pre-release (version: 3.0.4)

I hope this helps. Thanks!

@lepapareil
Copy link
Author

Thks for your reactivity ! I'll test it as soon as possible :)

@ran-jit
Copy link
Owner

ran-jit commented Feb 6, 2020

I tested new changes (version: 3.0.4) and it works fine :)

@lepapareil
Copy link
Author

thks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants