New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit spray id during the join event #17

Closed

folkvir opened this issue Feb 1, 2017 · 1 comment

Member

folkvir commented Feb 1, 2017 •

edited

Loading

Hi !
It would be very greatful to emit the id when you emit the join event.

Here is the code to change (line 101/102, spray.js) :

callbacks.onReady = function(id){
  onReadyFunction && onReadyFunction(id);
  // #D emit a join event
  self.emit('join');
};

to

self.emit('join', id);

If you can do it with a NPM release it would be great !

Member Author

folkvir commented Oct 24, 2018

No longer needed with the new version coming.

folkvir closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment