Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes version can be editable when quitting RD with deployment profiles #5047

Closed
Tracked by #4968
IsaSih opened this issue Jun 24, 2023 · 0 comments · Fixed by #5058
Closed
Tracked by #4968

Kubernetes version can be editable when quitting RD with deployment profiles #5047

IsaSih opened this issue Jun 24, 2023 · 0 comments · Fixed by #5058
Assignees
Labels
area/deployment Deployment profiles kind/bug Something isn't working release-note
Milestone

Comments

@IsaSih
Copy link
Contributor

IsaSih commented Jun 24, 2023

Actual Behavior

Given a locked deployment profile, the kubernetes version can be editable via rdctl start even if this field is locked in the profile

Steps to Reproduce

  1. Create a SYSTEM deployment profile (file under field Additional Information)
  2. Start Rancher Desktop
  3. Quit the application via tray menu/ run rdctl shutdown
  4. Try to change the value of the locked field via rdctl start
  5. Verify if the new settings is applied

Result

Rancher Desktop starts with no errors and the locked kubernetes version is actually editable via rdctl start.


"kubernetes": {
    "version": "1.23.16",
    "port": 6443,
    "enabled": true,
    "options": {
      "traefik": true,
      "flannel": true
    }

iguimaraes@isasih ~ % rdctl shutdown 
Shutting down.
iguimaraes@isasih ~ % rdctl start --kubernetes.version 1.27.2                                      
INFO[0000] About to launch /usr/bin/open -a /Applications/Rancher Desktop.app --args --kubernetes.version 1.27.2 ... 

Expected Behavior

Rancher Desktop should throw an error dialog and prevent the application to start with a value other than the specified in the locked profile.

Additional Information

profile.txt

Rancher Desktop Version

1.9.0-19-g6ccc9ccb

Rancher Desktop K8s Version

1.23.16

Which container engine are you using?

moby (docker cli)

What operating system are you using?

macOS

Operating System / Build Version

macOS Monterey

What CPU architecture are you using?

arm64 (Apple Silicon)

Linux only: what package format did you use to install Rancher Desktop?

None

Windows User Only

No response

@IsaSih IsaSih added kind/bug Something isn't working regression Functionality was working in a previous release and is now broken area/deployment Deployment profiles labels Jun 24, 2023
@IsaSih IsaSih added this to the 1.9.1 milestone Jun 24, 2023
@gaktive gaktive modified the milestones: 1.9.1, 1.10 Jun 26, 2023
@gaktive gaktive removed the regression Functionality was working in a previous release and is now broken label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment Deployment profiles kind/bug Something isn't working release-note
Projects
None yet
3 participants