Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot delete a no-proxy host #5366

Closed
IsaSih opened this issue Aug 18, 2023 · 1 comment · Fixed by #5379 or #5445
Closed

User cannot delete a no-proxy host #5366

IsaSih opened this issue Aug 18, 2023 · 1 comment · Fixed by #5379 or #5445
Assignees
Labels
area/proxy kind/bug Something isn't working
Milestone

Comments

@IsaSih
Copy link
Contributor

IsaSih commented Aug 18, 2023

Actual Behavior

By trying to delete a host from the no-proxy list, the Preferences dialog displays an error dialog with the message: "Errors in proposed settings: field "experimental.virtualMachine.proxy.noproxy" has duplicate entries: "", that blocks the user to save the changes.

Steps to Reproduce

  1. Go to Preferences > WSL > proxy
  2. Hit enter and leave the new line empty
  3. Delete a host from the leaving the line empty
  4. Check the error message that pops up

Result

the Preferences dialog displays an error dialog with the message: "Errors in proposed settings: field "experimental.virtualMachine.proxy.noproxy" has duplicate entries: "", that blocks the user to save the changes.

no-proxy

Expected Behavior

User must be able to delete hosts and successfully save the changes

Additional Information

The exclusion of whitespaces in the no-proxy list can prevent this behaviour

Rancher Desktop Version

1.9.1-520-g18b7fa88

Rancher Desktop K8s Version

N/A

Which container engine are you using?

containerd (nerdctl)

What operating system are you using?

Windows

Operating System / Build Version

windows 11

What CPU architecture are you using?

x64

Linux only: what package format did you use to install Rancher Desktop?

None

Windows User Only

No response

@IsaSih IsaSih added kind/bug Something isn't working area/proxy priority/0 Work needs to go into the next release or force a patch labels Aug 18, 2023
@IsaSih IsaSih added this to the 1.10 milestone Aug 18, 2023
@rak-phillip rak-phillip assigned s0nea and unassigned s0nea Aug 18, 2023
@IsaSih IsaSih changed the title Use cannot delete a no-proxy host User cannot delete a no-proxy host Aug 19, 2023
@IsaSih
Copy link
Contributor Author

IsaSih commented Aug 31, 2023

Reopening the issue, as the behavior did not change. Tested on windows 11, with build https://github.com/rancher-sandbox/rancher-desktop/actions/runs/6031736436

@IsaSih IsaSih reopened this Aug 31, 2023
@gaktive gaktive removed the priority/0 Work needs to go into the next release or force a patch label Sep 5, 2023
@gaktive gaktive modified the milestones: 1.10, 1.11 Sep 5, 2023
@jandubois jandubois modified the milestones: 1.11, 1.10 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment