Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports dropdown clipped by table boundaries #5759

Closed
Tracked by #5841 ...
rak-phillip opened this issue Oct 17, 2023 · 2 comments · Fixed by #5986
Closed
Tracked by #5841 ...

Ports dropdown clipped by table boundaries #5759

rak-phillip opened this issue Oct 17, 2023 · 2 comments · Fixed by #5986
Assignees
Milestone

Comments

@rak-phillip
Copy link
Contributor

rak-phillip commented Oct 17, 2023

When the dropdown list for ports is displayed at the bottom of the Containers page, it is cut off by the table. This makes it difficult to select the desired port.

Steps to reproduce

Make sure that a container is created with multiple ports mapped. The following command will run an nginx docker container with 5 different ports mapped to the container:

docker run -d -p 8080:80 -p 8081:81 -p 8082:82 -p 8083:83 -p 8084:84 nginx
  1. Go to the Containers page
  2. Sort the Containers table so that the container with many mapped ports is at the bottom of the list
  3. Hover over the more... dropdown for ports

Expected behavior

The dropdown list should be displayed fully, without being cut off by the table.

Actual behavior:

The dropdown list is cut off by the table, making it difficult to select the desired port.

Screenshots

Example of dropdown list cut off by the table

image

Example of the dropdown list displaying properly when at the top of the list

image

@IsaSih
Copy link
Contributor

IsaSih commented Dec 7, 2023

Is this behavior expected? There's still the ... to expose all the ports, but the list is brought above the row, not under. Or should all the ports be displayed in the table, with no cuts?

Image

@rak-phillip
Copy link
Contributor Author

Is this behavior expected? There's still the ... to expose all the ports, but the list is brought above the row, not under. Or should all the ports be displayed in the table, with no cuts?

It's expected. The problem that the issue describes had to deal with the fact that the popover could render menu options outside of the viewport, making the completely inaccessible.

There's not enough space in the table to display all of the ports in all scenarios, so the popover is still used. The main difference being that it will try to calculate if it should display above or below so that all of ports in the popover remain selectable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants