Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Cleanup of ManagedOSVersion orphans #17

Closed
Tracked by #58
mudler opened this issue Apr 5, 2022 · 1 comment · Fixed by #20
Closed
Tracked by #58

Cleanup of ManagedOSVersion orphans #17

mudler opened this issue Apr 5, 2022 · 1 comment · Fixed by #20
Assignees
Labels

Comments

@mudler
Copy link
Contributor

mudler commented Apr 5, 2022

At the moment ManagedOSVersion created by the controller don't have an owner set, so cleaning up a ManagedOSVersionChannel doesn't cleanup available versions.

Ideally we should set the VersionChannel as owner of ManagedOSVersion, allowing the resources to be cleaned up in cascade.

e.g. when creating the resource

OwnerReferences: []metav1.OwnerReference{
		*metav1.NewControllerRef(..., schema.GroupVersionKind{
			Group:   v1alpha1.SchemeGroupVersion.Group,
			Version: v1alpha1.SchemeGroupVersion.Version,
			Kind:    "...",
		}),
	},

Follow up of : #14

@davidcassany
Copy link
Contributor

I am starting to have a look at this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants