Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SURE-2565) Support for managed identity in AKS #103

Open
kkaempf opened this issue Feb 4, 2023 · 2 comments
Open

(SURE-2565) Support for managed identity in AKS #103

kkaempf opened this issue Feb 4, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@kkaempf
Copy link

kkaempf commented Feb 4, 2023

See also rancher/rancher#27559

We got an issue when using Rancher to provision Windows nodes using Managed identities for Azure resources (formerly known as Managed Service Identity - MSI).

Rancher provisioning script only handles cases where we authenticate using service principal and will not work properly with managed identity.

Relevant code: https://github.com/rancher/rke-tools/blob/a23ff70c7a1ae0b8ec5c91bc56d51b0ad9f541ad/windows/cloud-provider.psm1#L70

Currently, we have to patch the file in runtime to use az login --identity instead of az login --service-principal

Steps to reproduce (least amount of steps as possible):

Create an AKS cluster without specifying any Service Principal

Result:

An AKS cluster is created using the --enable-managed-identity flag.

Other details that may be helpful:

The feature is stable in AKS: https://docs.microsoft.com/en-us/azure/aks/use-managed-identity

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.4.4
Installation option (single install/HA): single container

The UI presents mandatory fields to enter the SP for AKS; I propose to add a ratio button where the user can select to create a MI instead.

@kkaempf kkaempf added area/windows kind/enhancement New feature or request JIRA Must shout area/ui labels Apr 5, 2023
@kkaempf kkaempf added this to the 2024-Q1-v2.8x milestone Dec 8, 2023
@cpinjani cpinjani self-assigned this Dec 13, 2023
@cpinjani
Copy link

cpinjani commented Dec 21, 2023

Validated on build: v2.8-7113f094007e3105a906b414fe18ee370c77bb5e-head

As stated in issue description and reported version v2.4 - "The UI presents mandatory fields to enter the SP for AKS; I propose to add a ratio button where the user can select to create a MI instead."

Rancher v2.4:
image

However, we still use service principal for AKS clusters (not managed identity)
prerequisites-in-microsoft-azure

image

@kkaempf @davidstauffer Please review this, as support for it is not added yet.

@cpinjani
Copy link

cpinjani commented Jan 3, 2024

Moving to Backlog, cc: @mjura

@cpinjani cpinjani removed their assignment Feb 5, 2024
@kkaempf kkaempf modified the milestones: v2.8-Next1, v2.9.0 Mar 12, 2024
@mjura mjura self-assigned this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants