Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport v2.8.next1] Custom banner header without fontSize breaks top navigation #10357

Closed
github-actions bot opened this issue Jan 30, 2024 · 3 comments · Fixed by #10369
Closed

[backport v2.8.next1] Custom banner header without fontSize breaks top navigation #10357

github-actions bot opened this issue Jan 30, 2024 · 3 comments · Fixed by #10369
Assignees
Milestone

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024

This is a backport issue for #10140, automatically created via GitHub Actions workflow initiated by @richard-cox

Original issue body:

Setup

  • Rancher version: v2.8.0
  • Rancher UI Extensions: None
  • Browser type & version: Chrome

Describe the bug
In Rancher 2.7.9, if you customized your UI to have a custom header banner, the fontSize is not a required field. This worked fine and it fell back to the default of 14px.

In Rancher 2.8.0, fontSize not being set will result in the entire Vue component failing to render, breaking navigation.

The error comes from this line: https://github.com/rancher/dashboard/blob/master/shell/components/nav/TopLevelMenu.vue#L79
which will be undefined if the fontSize is not set.

To Reproduce
Set a custom header banner without a fontSize defined.

Result
Your navigation will no longer render and you will see console errors.

Expected Result
The navbar should work with a fallback default fontSize

@richard-cox
Copy link
Member

Workaround details in #10368 (comment)

@richard-cox
Copy link
Member

to reproduce bug #10369 (comment)

@IsaSih
Copy link

IsaSih commented Mar 14, 2024

Tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants