-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steve socket is spammed on fresh visit to node detail page #10668
Comments
/backport v2.7.next2 |
/backport v2.8.next2 |
This is a manual test candidate. This require debug level logs to be enabled on Rancher and monitor log messages. @yonasberhe23 |
I noticed there's no I see the following I see the following Errors occurs for resourceTypes: node, pod and apps.deployment |
You'll need to check The main thing to confirm is that there's not lots and lots of repeated messages every second (green socket message sent, resource.start, resource.error, resource.start, green socket message sent, etc) |
Tests pass on v2.9-16190ecee0aa3fb4aa570aa0fc932a36d9dcd082-head |
Setup
Describe the bug
resource.error
message when watching an individual resource over websocketresource.error
oftoo old
which would result in socket spamresource.error
message is now returned when we try to watch a resource we should notmetrics.k8s.io.nodemetrics
resource used in the node detail pageresource.error
though isn't one we let stick, so we just try toresource.start
/ watch again... which results in the same resource.error, repeat ad nauseamTo Reproduce
<rancher url>/v1/schemas/metrics.k8s.io.nodemetrics
apply
command from https://github.com/kubernetes-sigs/metrics-serverResult
messages
sent over the cluster socket repeat the resource.start, resource.stop / resource.error, resource.start cycleExpected Result
Screenshots
![image](https://private-user-images.githubusercontent.com/18697775/314603209-7bb47a6b-a665-4c62-94fe-fa0d81b7b5cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5MDI0MjAsIm5iZiI6MTcyMzkwMjEyMCwicGF0aCI6Ii8xODY5Nzc3NS8zMTQ2MDMyMDktN2JiNDdhNmItYTY2NS00YzYyLTk0ZmUtZmEwZDgxYjdiNWNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDEzNDIwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4YzNlMTIwMWI5NDE1M2Y2MmU0Mzk4ZmUzNzg2YTVkZmMyMDdlYTQ0NTNkYTE1ODM1NTcxNTVkMzc3MmEwNDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.cpoKVK4bJaWSOEP34bxQ0h3lOF0lj9F5UGbhpo2redU)
The text was updated successfully, but these errors were encountered: