Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @rancher/icons package for npm #7477

Closed
cnotv opened this issue Nov 17, 2022 · 5 comments · Fixed by #11109
Closed

Create @rancher/icons package for npm #7477

cnotv opened this issue Nov 17, 2022 · 5 comments · Fixed by #11109
Labels
area/ci CI and automation related, e.g. GitHub Actions area/icons Anything related to @rancher/icons kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@cnotv
Copy link
Contributor

cnotv commented Nov 17, 2022

Describe

From the existing rancher/icon repository update CI to publish the build on NPM.

Context

We currently import the library as git reference, while instead we want to include under the scope @rancher also the icons.

@cnotv cnotv added kind/tech-debt Technical debt area/ci CI and automation related, e.g. GitHub Actions area/icons Anything related to @rancher/icons labels Nov 17, 2022
@cnotv cnotv added this to the 2.7.1 milestone Nov 17, 2022
@cnotv cnotv modified the milestones: 2.7.1, v2.7.1 Nov 17, 2022
@nwmac
Copy link
Member

nwmac commented Dec 16, 2022

As part of this work, we should also update Dashboard to reference icons via the npm package rather than by a GitHub reference

@nwmac nwmac modified the milestones: v2.7.next1, v2.7.next2 Dec 16, 2022
@cnotv
Copy link
Contributor Author

cnotv commented Dec 16, 2022

It's also worth mentioning that something already exists in NPM
https://www.npmjs.com/package/rancher-icons

@cnotv
Copy link
Contributor Author

cnotv commented Dec 16, 2022

@nwmac the idea is to have separated implementations of this, as you cannot actually add the library to rancher/dashboard till you merge the changes in rancher/icons. The aim is to be able to do both in separated instances.
It would not be possible to do an actual review in that case.

What would you suggest otherwise as process for the review?

@nwmac
Copy link
Member

nwmac commented Dec 16, 2022

That's an old package - I think we'd publish as @rancher/icons - I don't think we have anyone who has access to that package.

We can have 2 PRs - 1 for the changes to publish, 1 for dashboard changes - both linked to fix this issue. The icons PR can be reviewed first, the icon package reviewed and then the dashboard PR reviewed.

@cnotv
Copy link
Contributor Author

cnotv commented Dec 16, 2022

Deal.

@gaktive gaktive added the QA/None label May 8, 2023
@cnotv cnotv modified the milestones: v2.7.next2, v2.7.next3 May 22, 2023
@gaktive gaktive modified the milestones: v2.7.next3, v2.8.next4 Jul 17, 2023
@gaktive gaktive modified the milestones: v2.8.0, v2.8.next1 Sep 22, 2023
@nwmac nwmac modified the milestones: v2.8.next1, v2.8.next2 Nov 28, 2023
@nwmac nwmac modified the milestones: v2.8.next2, v2.10.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI and automation related, e.g. GitHub Actions area/icons Anything related to @rancher/icons kind/tech-debt Technical debt QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants