-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create @rancher/icons package for npm #7477
Comments
As part of this work, we should also update Dashboard to reference icons via the npm package rather than by a GitHub reference |
It's also worth mentioning that something already exists in NPM |
@nwmac the idea is to have separated implementations of this, as you cannot actually add the library to What would you suggest otherwise as process for the review? |
That's an old package - I think we'd publish as @rancher/icons - I don't think we have anyone who has access to that package. We can have 2 PRs - 1 for the changes to publish, 1 for dashboard changes - both linked to fix this issue. The icons PR can be reviewed first, the icon package reviewed and then the dashboard PR reviewed. |
Deal. |
Describe
From the existing
rancher/icon
repository update CI to publish the build on NPM.Context
We currently import the library as git reference, while instead we want to include under the scope
@rancher
also the icons.The text was updated successfully, but these errors were encountered: