Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add or edit cluster labels via the UI #3086

Closed
digiserg opened this issue May 25, 2021 · 5 comments
Closed

Cannot add or edit cluster labels via the UI #3086

digiserg opened this issue May 25, 2021 · 5 comments
Assignees
Milestone

Comments

@digiserg
Copy link

Version: v2.5.8
Installer: helm chart
Cluster: standalone lab with k3s

When I edit the cluster labels via the Web UI the changes are not applied back to the cluster. If I use the YAML editor however it does work as expected.

image

@89luca89
Copy link

89luca89 commented May 25, 2021

I would add also that patching the resource via kubectl, works as expected, and the edit yaml view is correctly updated.
Just the UI seems disjoined from the internal representation

EDIT: adding screenshots

Editing the resource manually

Screenshot_2021-05-25_21-04-33

Applying it

Screenshot_2021-05-25_21-04-24

Result in UI

Screenshot_2021-05-25_21-03-43

Screenshot_2021-05-25_21-06-40

@nwmac
Copy link
Member

nwmac commented Feb 16, 2022

@aalves08 see if you can validate- 2.5 UI shown - but the code is the same in 2.6

@aalves08
Copy link
Contributor

@nwmac works as expected in 2.6-head. No issues here with labels on Clusters in Fleet. Shall we close this?

@nwmac
Copy link
Member

nwmac commented Feb 16, 2022

@aalves08 Move it to 'To Test' -> remove the [zube]: Working label and add [zube]: To Test - we almost always do that and don't close issues - QA will validate again and close the issue.

@nwmac nwmac modified the milestones: v2.6.x, v2.6.4 Feb 16, 2022
@aalves08 aalves08 assigned Shavindra and unassigned Shavindra Feb 16, 2022
@deniseschannon deniseschannon added the team/area3 Helm Yes! label Feb 20, 2022
@davidnuzik
Copy link

I cannot reproduce this in v2.6.3 actually - this was likely fixed somewhere in the Rancher v2.6 history. I'm changing the milestone to 2.6.3 since no work was done (this is essentially not a "2.6.4 issue").

Reproduction Environment:

Rancher version: v2.6.3
Rancher cluster type: single-node docker install
Docker version: 20.10

Downstream cluster type: RKE2
Downstream K8s version: v1.21.9+rke2r1

Reproduction steps:

  1. Create a downstream cluster.
  2. Once the cluster is fully ready, navigate to the Continuous Delivery page from the left nav pane.
  3. Click on Clusters. Then, to the right of the downstream cluster name, click on the vertical "..." and chose the Edit Config option.
  4. Notice the Labels section - I can successfully add or edit cluster labels here. The screenshot shows me adding a label. I confirmed it took. When I re-edit I still see it there. I also changed the label to a different value upon the second time editing and this change took. I can edit a 3rd time and see my change is still there.

image

Additional Info:
Fixed in v2.6.3 or possibly sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants