Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Drain Before Delete" support for RKE2 machine pools #4448

Closed
Tracked by #3346
snasovich opened this issue Oct 26, 2021 · 5 comments
Closed
Tracked by #3346

"Drain Before Delete" support for RKE2 machine pools #4448

snasovich opened this issue Oct 26, 2021 · 5 comments

Comments

@snasovich
Copy link
Contributor

Detailed Description
For RKE1-provisioned clusters, there is currently an option to specify whether nodes should be drained before deletion for each node pool:
image

For RKE2-provisioned clusters, we want the same functionality to be available, probably by adding a checkbox somewhere on the base pool details section highlighted below:
image

Context
This is needed for RKE2 provisioning parity with RKE1

Additional Details
Backend support is needed: rancher/rancher#35274

@snasovich
Copy link
Contributor Author

Backend changes done per rancher/rancher#35274, should no longer be blocked by backend. If clarifications are needed, please contact @jakefhyde who implemented backend changes (there is a good summary here).

@ronhorton
Copy link

PASS verified in 2.6-head Commit ID cd3c9d7

  1. created downstream rke2 cluster
  2. 'drain before delete' is available now for rke2
  3. brought up cluster
  4. checked logs - no errors
  5. deleted cluster
  6. cluster was deleted & removed from downstream provider

@sowmyav27
Copy link

Reopening to test a few more scenarios

@anupama2501
Copy link

Verified on v2.6-head 8c785a1 as part of this issue:
rancher/rancher#35274 (comment)

@jtravee
Copy link

jtravee commented Mar 16, 2022

Confirmed with @catherineluse and @gaktive to add release note label.

@zube zube bot removed the [zube]: Done label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants