-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Drain Before Delete" support for RKE2 machine pools #4448
Comments
Backend changes done per rancher/rancher#35274, should no longer be blocked by backend. If clarifications are needed, please contact @jakefhyde who implemented backend changes (there is a good summary here). |
PASS verified in
|
Reopening to test a few more scenarios |
Verified on v2.6-head 8c785a1 as part of this issue: |
Confirmed with @catherineluse and @gaktive to add |
Detailed Description
![image](https://user-images.githubusercontent.com/85187633/138793914-23651cd1-89ca-4f1c-b2d4-dc594ab03c8f.png)
For RKE1-provisioned clusters, there is currently an option to specify whether nodes should be drained before deletion for each node pool:
For RKE2-provisioned clusters, we want the same functionality to be available, probably by adding a checkbox somewhere on the base pool details section highlighted below:
![image](https://user-images.githubusercontent.com/85187633/138794310-64fa0386-30a8-4db6-a58e-d8da6e4edc5b.png)
Context
This is needed for RKE2 provisioning parity with RKE1
Additional Details
Backend support is needed: rancher/rancher#35274
The text was updated successfully, but these errors were encountered: