Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Rollback Diff view #4636

Closed
nwmac opened this issue Nov 23, 2021 · 4 comments · Fixed by #5244
Closed

Improvements to the Rollback Diff view #4636

nwmac opened this issue Nov 23, 2021 · 4 comments · Fixed by #5244

Comments

@nwmac
Copy link
Member

nwmac commented Nov 23, 2021

  • Add in ability to switch between the side-by-side and inline diff
  • Collapse (or hide) the fields that are non-standard - check the Ember UI for the list of these
@ronhorton
Copy link

Reopening 2.6-head Commit ID 20d20a3

  1. created deployment - nginx:1.21.3
  2. edit config on new deployment - change to nginx:lastest
  3. Show diff good - extraneous information not shown (such as kind:)
  4. Click Rollback

Expected: deployment rolls back to original value

Actual: error that the deployment can not be found (reproducible 100%)
Screen Shot 2022-02-17 at 3 50 40 PM

@nwmac
Copy link
Member Author

nwmac commented Mar 3, 2022

Caused by same issue as #4664

PR in review

@ronhorton
Copy link

Pass Verified fixed in 2.6-head Commit ID f2a4147

  1. created deployment with nginx 1.21.3
  2. edit config on deployment to nginx:latest
  3. rollback to previous deployment (1.21.3)
  4. show diff
  5. rollback

rollback to previous version functions as expected

@jtravee
Copy link

jtravee commented Mar 16, 2022

Confirmed with @catherineluse and @gaktive to add release note label.

@zube zube bot removed the [zube]: Done label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants