Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet: Show clusters applicable to a git repo #4929

Closed
richard-cox opened this issue Jan 17, 2022 · 4 comments
Closed

Fleet: Show clusters applicable to a git repo #4929

richard-cox opened this issue Jan 17, 2022 · 4 comments

Comments

@richard-cox
Copy link
Member

Detailed Description

  • When a git repo is created and it doesn't apply to any clusters the detail page can show misleading information
    • Number of 'ready' resources yet no actual resources
  • On the git repo detail page we should list clusters that the repo applies to
    • Discussion: We should also maybe show a warning somewhere when a repo doesn't apply to any?

Context

@nwmac
Copy link
Member

nwmac commented Feb 4, 2022

image

(See clusters ready column)

@nwmac
Copy link
Member

nwmac commented Feb 4, 2022

Currently looks like this when you target a group that does not have any matching clusters:

image

Task is to update the 'Clusters Ready' column so that when it is a Group, it shows the number of clusters in the group as well - e.g. 0/0 - when the number in the group is 0, it also shows a waring icon with a hover tooltip 'There are no clusters in this Cluster Group'

@davidnuzik
Copy link

My checks PASSED

Reproduction Steps:

Not required. Issue is well understood and reproduced recently. Before the change the total clusters ready was not show and there was no ! icon showing an issue.


Validation Environment:

Rancher version: v2.6-head `` pulled on 2/24/2022
Rancher cluster type: single-node docker install
Docker version: 20.10

Downstream cluster type: RKE2
Downstream K8s version: v1.21.9+rke2r1

Validation steps:

  1. Create a GitRepo on the Continuous Delivery page (left nav bar). I just used fleet-examples (https://github.com/rancher/fleet-examples.git is the Repo URL) and set the path to /single-cluster/helm. In the dropdown for "Deploy To", pick "No Clusters". Submit.
  2. Notice the new changes as pictured below. We now see the total count of clusters targeted. We also see a warning icon when deploys to zero clusters (none targeted). This is basically the change (see the PR for details).

image

@jtravee
Copy link

jtravee commented Mar 16, 2022

Confirmed with @catherineluse and @gaktive to add release note label.

@zube zube bot removed the [zube]: Done label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants