Hosted cluster provisioning page shows registration tab while updating / upgrading the cluster

[slickwarren]

Setup

• Rancher version: v2.7.2-rc7
• Browser type & version: any

Describe the bug

when upgrading a hosted cluster, the registration page will show on the provisioning tab

To Reproduce

• provision a hosted (say, GKE) cluster through rancher
• wait for the cluster to get to an active state
• upgrade the cluster
• go to the cluster's manage page (select the cluster from the list on the cluster management page)

Result
a registration tab is shown by default

Expected Result

registration tab should not show for hosted clusters

Screenshots

---

Edit:
now, the ask is to:
modify/expand on the existing warning on that page, You should not import a cluster which has already been connected to another instance of Rancher as it will lead to data corruption

[cnotv]

Not able to reproduce it with RKE2 hosting on DO. Does maybe have to do with GKE? I also see the tag Unavailable?
I have also only Updating state clusters, so not so sure to be able to make it possible to reproduce it to Active state.

[kwwii]

We should check if you can import a hosted cluster.

@slickwarren Can you provide us an environment for testing?

[mantis-toboggan-md]

I'm unsure exactly when the registration tab should be shown for GKE/AKS/EKS clusters. After looking around the relevant code I found a few issues specifically asking that the tab be shown:
#6838
#6036

It sounds like the tab needs to be shown for private clusters, but going off of the comment here we can't tell if a hosted cluster is private or not so we're showing that tab for all hosted clusters that are not 'ready'. Could @jordojordo and/or @markusewalker chime in with some clarification for this issue?

[markusewalker]

@mantis-toboggan-md your understanding is correct. tl;dr version is private clusters did not have the registration tab present, which is needed to complete cluster provisioning through Rancher or importing into Rancher. The end result was to show the Registration tab with the conditional specified in that comment.

As far as this issue is concerned, this is the current expected design.

[mantis-toboggan-md]

Okay, it sounds like there's nothing for us to change here - can we close this issue out @slickwarren ?

[slickwarren]

as mentioned above, since the cluster is indistinguishable from a private hosted cluster, we must keep the registration tab available. Curious if this would happen if a user runs any of the steps listed there on a non-private cluster.

Is there any way just to add a warning for hosted clusters on the registration tab stating that no action is necessary if using a publicly available cluster? Just so that, if users are confused and/or click on the tab, it is clear that they should not use it?

[mantis-toboggan-md]

I think we could modify/expand on the existing warning on that page, You should not import a cluster which has already been connected to another instance of Rancher as it will lead to data corruption
Though I personally don't know enough about this functionality to phrase it well myself. In either case, given the timeline for 2.7.2 could this be bumped into 2.7 q2? cc @gaktive

[gaktive]

@mantis-toboggan-md we should bump follow up work that isn't a blocker to Q2. Although reducing confusion would help with this highly complicated feature, this could be a release note or something in the docs for this release.

@sowmyav27 how does that sound?