Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Chinese. The content of the Severity drop-down box in Alerting Rules should not be translated into Chinese. #9923

Closed
kingsd041 opened this issue Oct 16, 2023 · 2 comments · Fixed by #9925 or #10899
Closed

Switch to Chinese. The content of the Severity drop-down box in Alerting Rules should not be translated into Chinese. #9923

kingsd041 opened this issue Oct 16, 2023 · 2 comments · Fixed by #9925 or #10899
Assignees
@torchiaf
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.9.0

Comments

@kingsd041
Copy link

Setup

  • Rancher version: v2.7.8
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

Switch to Chinese and add Prometheusrule. The content in the Severity drop-down box (critica, warning, none) does not need to be in Chinese. Otherwise, after saving, view the configuration through yaml. The content of the Severity field is in Chinese.

image image
@ly5156 ly5156 mentioned this issue Oct 16, 2023
Merged
@richard-cox richard-cox added this to the v2.8.next1 milestone Oct 16, 2023
@github-actions github-actions bot reopened this Nov 24, 2023
@nwmac nwmac added the QA/manual-test Indicates issue requires manually testing label Jan 30, 2024
@nwmac nwmac added the candidate-automation Candidate for being covered by automated tests label Apr 13, 2024
@aalves08 aalves08 mentioned this issue Apr 29, 2024
Merged
7 tasks
@aalves08 aalves08 added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed QA/manual-test Indicates issue requires manually testing candidate-automation Candidate for being covered by automated tests labels Apr 30, 2024
@aalves08
Copy link
Contributor

Updated QA labels since I've added an e2e test with #10899

@izaac
Copy link
Contributor

izaac commented May 8, 2024

E2E coverage looks good to me. Moving to done.

@nwmac nwmac closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torchiaf torchiaf

Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.9.0
7 participants
@izaac @nwmac @gaktive @richard-cox @kingsd041 @torchiaf @aalves08