Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[forward] Azure Webhook Support [SURE-7047] #1974

Open
manno opened this issue Nov 28, 2023 · 4 comments
Open

[forward] Azure Webhook Support [SURE-7047] #1974

manno opened this issue Nov 28, 2023 · 4 comments
Assignees
@raulcabello @thehejik
Labels
JIRA Must shout
Milestone
v2.9.0

Comments

@manno
Copy link
Member

manno commented Nov 28, 2023 •
edited

forwardport of #1997
@manno manno added the JIRA Must shout label Nov 28, 2023
@manno manno added this to the 2024-Q1-2.8x milestone Nov 28, 2023
@manno
Copy link
Member Author

manno commented Dec 1, 2023

/forwardport v2.9.0 release/v0.9

@manno
Copy link
Member Author

manno commented Dec 1, 2023

/backport v2.9.0 release/v0.9

@manno manno changed the title Azure Webhook Support [SURE-7047] [v0.9] Azure Webhook Support [SURE-7047] Dec 1, 2023
@manno manno removed their assignment Dec 1, 2023
@manno manno modified the milestones: 2024-Q1-2.8x, v2.9.0 Dec 7, 2023
@manno manno changed the title [v0.9] Azure Webhook Support [SURE-7047] Azure Webhook Support [SURE-7047] Dec 7, 2023
@manno manno changed the title Azure Webhook Support [SURE-7047] [forward] Azure Webhook Support [SURE-7047] Dec 7, 2023
@raulcabello raulcabello self-assigned this Dec 19, 2023
@raulcabello raulcabello mentioned this issue Dec 22, 2023
Closed
@raulcabello raulcabello mentioned this issue Jan 17, 2024
Merged
@raulcabello
Copy link
Contributor

QA Template

Solution

Add webhook support for Azure Webhooks. It works the same way as existing webhooks for GitHub, Gitlab and BitBucket

Testing

  • Verify webhook in azure are working when no basic authentication is provided
  • Wrong basic auth credentials should show an error, and it should not update the Bundle
  • Valid auth credentials should work fine
  • Webhooks for other providers (GitHub, Gitlab and BitBucket) should keep working

Additional notes

@thehejik thehejik self-assigned this Apr 19, 2024
@thehejik thehejik mentioned this issue Apr 22, 2024
Closed
@thehejik
Copy link

Seems this is working with private Azure HTTPS repo but there are two issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcabello raulcabello

@thehejik thehejik

Labels
JIRA Must shout
Projects
Fleet
Status: Needs QA review
Milestone
v2.9.0
Development

No branches or pull requests
4 participants
@kkaempf @manno @raulcabello @thehejik