Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespaceLabels does not work as a targetCustomizations #2262

Closed
1 task done
jhoblitt opened this issue Mar 23, 2024 · 4 comments
Closed
1 task done

namespaceLabels does not work as a targetCustomizations #2262

jhoblitt opened this issue Mar 23, 2024 · 4 comments

Comments

@jhoblitt
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I attempted to add additional namespace labels as targetCustomizations[0].namespaceLabels and no change was made to the existing labels on the default namespace.

Expected Behavior

I expected either the top level namespaceLabels to merged with targetCustomization namespaceLabels or overridden completely. I did not expect nothing at all to happen as namespaceLabels is part of BundleDeploymentOptions.

Steps To Reproduce

---
defaultNamespace: &name mimir
labels:
  bundle: *name
namespaceLabels:
  foo: bar
helm:
  chart: &chart mimir-distributed
  releaseName: *chart
  repo: https://grafana.github.io/helm-charts
  version: 5.2.0
  timeoutSeconds: 600
  waitForJobs: true
targetCustomizations:
  - name: ruka
    clusterName: ruka
    helm:
      valuesFiles:
        - overlays/ruka/values.yaml
    namespaceLabels:
      this.is/a: test

Environment

- Architecture: amd64
- Fleet Version: 0.90 / rancher 2.8.2
- Cluster:
  - Provider: rke[1]
  - Options: extra cheese
  - Kubernetes Version: v1.25.9

Logs

No response

Anything else?

No response

@jhoblitt
Copy link
Contributor Author

Is this possibly related to #1994?

@manno
Copy link
Member

manno commented Apr 10, 2024

@manno manno added this to the v2.9-Next1 milestone Apr 10, 2024
@manno manno added JIRA Must shout kind/enhancement and removed kind/bug JIRA Must shout labels Apr 10, 2024
@manno manno modified the milestones: v2.9-Next1, v2.10.0 Apr 10, 2024
@jhoblitt
Copy link
Contributor Author

My use case for wanting to customize namsepaceLabels is to use different prometheus scraping labels on different groups of clusters.

@manno
Copy link
Member

manno commented Jul 25, 2024

Closing this as we're tracking the feature in #2441

@manno manno closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants