Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps/deployments are not getting deleted after removing GitRepos #263

Closed
paralika opened this issue Feb 4, 2021 · 4 comments
Closed

Apps/deployments are not getting deleted after removing GitRepos #263

paralika opened this issue Feb 4, 2021 · 4 comments
Assignees
Milestone

Comments

@paralika
Copy link

paralika commented Feb 4, 2021

Removing gitrepo does not remove deployments if the repository has helm charts and fleet.yaml

Steps:

  • Create gitrepo which is pointing to the repository which has helm charts and fleet.yaml
  • New deployment will be created (as per charts)
  • Delete gitrepo
  • gitrepo and bundle has been deleted but the deployments are not.

Rancher v2.5.5, Fleet version is 0.3.3.
gz#15818

@hyunsun
Copy link

hyunsun commented Feb 8, 2021

I experienced the same. In my test, the repo had two bundles, one with just raw manifests and the other with external helm chart, and the external helm chart left over when I delete the repo.

@travis-sobeck
Copy link

+1

@StrongMonkey
Copy link
Contributor

This one should be fixed in latest release of fleet by #294. Feel free to reopen the issue if you are still seeing that.

@sgapanovich
Copy link


Test Environment:

Rancher version: v2.6-head 4375161
Rancher cluster type: single-node docker install / HA
Docker version: 20.10
Fleet version: v0.3.8-rc2

Downstream cluster: 3 nodes ec2 cluster

Used "fleet-local" namespace to deploy resources to the local cluster and "fleet-default" to deploy resources to a downstream cluster


Testing:

  • used fleet examples https://github.com/rancher/fleet-examples/tree/master/single-cluster (all of them)
    • resources are deleted when the gitrepo is deleted
  • used 2 other gitrepos with different types of resources (deployments and services)
    • resources are deleted when the gitrepos are deleted
  • upgraded 2.5.5 rancher (0.3.3 fleet) to 2.6-head rancher (0.3.8-rc2 fleet) with some gitrepos added
    • gitrepos and bundles came back as "Modified" but pushing a new commit to the git repo or clicking "Force Update" worked and gitrepos + bundles became "Active"
      • resources are deleted when the gitrepos are deleted

@zube zube bot closed this as completed Nov 30, 2021
@zube zube bot removed the [zube]: Done label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants