[Cleanup] Types, ready-log-messages & closing connections #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
added
bug
iwilltry42
changed the title
- stream/follow logs: less api calls - retry on fatal error (K3s container restarting) - double check log line for init server (choose a later line, after which secondary servers succeed to connect)
iwilltry42
force-pushed
the
enhancement/close-connections
branch
from
5af209c
to
6e8b166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
This PR grew from just checking for leftover connections to a rather large cleanup of types to get a better oversight of various types.
Changes
initServerused only to determine the correct ready-log-messageIntenttype (cluster-create/cluster-start/node-create/node-start), as especially for the init server there are different log messages indicating that we can proceed with the next step*runtimeTypes.NodeLogsOptsparameter in GetNodeLogsTo-Do:
goto