Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cmd): add subcommands in one call #819

Merged
merged 1 commit into from
Oct 27, 2021
Merged

chore(cmd): add subcommands in one call #819

merged 1 commit into from
Oct 27, 2021

Conversation

moeryomenko
Copy link
Contributor

What

Add subcommands in one call.

Why

Reduce amount of jumps.

Before
swappy-20211025-230212

After
swappy-20211025-231353

@moeryomenko
chore(cmd): add subcommands by one call
0e42be9 
Signed-off-by: Maxim Eryomenko <moeryomenko@gmail.com>
iwilltry42
iwilltry42 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwilltry42 iwilltry42 assigned iwilltry42 and unassigned iwilltry42 Oct 27, 2021
@iwilltry42 iwilltry42 added scope/package pkg/ scope/cli Issue concerns the CLI (cmd/) and removed scope/package pkg/ labels Oct 27, 2021
@iwilltry42 iwilltry42 added this to the v5.0.2 milestone Oct 27, 2021
@iwilltry42
Copy link
Member

Thanks for your contribution @moeryomenko! :)

@iwilltry42 iwilltry42 changed the title chore(cmd): add subcommands by one call chore(cmd): add subcommands in one call Oct 27, 2021
@iwilltry42 iwilltry42 merged commit 407ced6 into k3d-io:main Oct 27, 2021
@moeryomenko moeryomenko deleted the style-add-in-one-call branch October 27, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
scope/cli Issue concerns the CLI (cmd/)
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moeryomenko @iwilltry42