Update to k8s 1.19 #2098
Merged
Update to k8s 1.19 #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we going to follow k/k up to golang 1.15? |
|
The minimum requirement for k8s 1.19 is golang 1.14.4, and since 1.15 is not officially out yet I think we should stick with 1.14. |
AkihiroSuda
reviewed
Aug 6, 2020
erikwilson
force-pushed
the
k8s-1.19
branch
18 times, most recently
from
af4c29a
to
274e74d
Compare
erikwilson
force-pushed
the
k8s-1.19
branch
2 times, most recently
from
88c1c20
to
9d9f03f
Compare
|
If you're waiting for a LGTM to push tags to rancher/kubernetes, then: LGTM |
erikwilson
force-pushed
the
k8s-1.19
branch
2 times, most recently
from
944476f
to
78a5dd9
Compare
brandond
reviewed
Aug 28, 2020
erikwilson
force-pushed
the
k8s-1.19
branch
2 times, most recently
from
aa586a4
to
fbb7343
Compare
briandowns
approved these changes
Aug 29, 2020
brandond
approved these changes
Aug 29, 2020
This was referenced Aug 29, 2020
Closed
|
@warmchang go was bumped to 1.15 you can see the commit here debf800 or look above |
|
@davidnuzik Actually I want to say whether we need to change the go.mod from "go 1.13" to "go 1.15": |
|
We probably could bump that as well, but it shouldn't be required as per golang/go#30791 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
k8s update to v1.19.0
Types of changes
Component Upgrade
Verification
Needs certified conformance test for cncf
Linked Issues
For #2020
Further comments