helm chart: helperPod - fix documentation or fix back setup (better)

[cr1st1p]

It looks like at a certain point you removed the possibility to completely define the helper pod definition, while you actually kept the helm chart's README.md still mentioning it.
Please do one of:
a) fix the README.md and document helperImage value (and remove configmap.helperPod),
b) revert back that change (7a55712)
c) allow adding helper pod annotations

Preferrably b) or c). Reason: under istio, I really need to add an annotation, so that the pod stops.

[cr1st1p]

For c), maybe add something along (untested if not defined):
....
name: helper-pod
{{ if .Values.helperImage.annotations }}
annotations:
{{ .Values.helperImage.annotations | toYaml | nindent 8 }}
{{ end }}
spec:
....

[justusbunsi]

My 2 ct:

It would be great if we were at least able to customize pod name and/or pod namespace. Preferably the whole template 😉.
Imaging having multiple provisioners with different settings in the same cluster. One maybe persists data and the other is fully ephemeral. At some point in time both provisioners might provision a PV at the very same time. That's when the static pod name will create conflicts.

[derekbit]

For c), maybe add something along (untested if not defined): .... name: helper-pod {{ if .Values.helperImage.annotations }} annotations: {{ .Values.helperImage.annotations | toYaml | nindent 8 }} {{ end }} spec: ....

@cr1st1p @justusbunsi

Welcome to submit a PR addressing the issue. Many thanks.

[justusbunsi]

@derekbit Took me a bit to come back to this issue. I provided a PR for it (#365). Please let me know if there's something that need to be changed.