Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-path-provisioner doesn't work on clusters without internet #84

Open
iirekm opened this issue May 11, 2020 · 3 comments
Open

local-path-provisioner doesn't work on clusters without internet #84

iirekm opened this issue May 11, 2020 · 3 comments

Comments

@iirekm
Copy link

iirekm commented May 11, 2020

Fixing Helm chart is easy: add HELPER_IMAGE with env var to point to the proper address of busybox.

But additionally imagePullSecrets has to be added to the create-xxxx pods generated by the provisioner and there's no way to do it.

@hwaastad
Copy link

@yasker this would be a minor change I think by extending the podpec in provisioner.go:

ImagePullSecrets: []v1.LocalObjectReference{
				{Name: p.pullSecret}, // should be loop of spec.imagepullsecrets
			},

We have met this issue our self having to use a private docker proxy.
I can add a PR for this one, but in my simple impl (since I have a limited knowledge of the go-client) I've added a pullproxy option to the provisioner (similar to the --helper-image). (Would probably be best if it was injected from the spec.imagepullsecrets from deployment,if possible)

@yasker
Copy link
Member

yasker commented Jun 24, 2020

Seems we should add an image pull secret option in the cmdline.

@vincent-herlemont
Copy link

If the PR #119 is merged, this issue shouldn't be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants