Create local volumes instead of hostPath #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code part LGTM. We do need a bit more documentation updates. Also, I am not using Velero so it would be helpful if someone else can give this PR a test with Velero. |
|
I will merge this for now. Let's test it for a few days before releasing the next version. |
yasker
added a commit
to yasker/local-path-provisioner
that referenced
this pull request
Aug 10, 2020
This reverts commit fb27d14. Local volumes breaks provisioner on RKE. Revert: rancher#91
yasker
added a commit
to yasker/local-path-provisioner
that referenced
this pull request
Aug 10, 2020
This reverts commit fb27d14. Local volumes breaks provisioner on RKE. Revert: rancher#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create local volumes instead of hostPath ones. Closes #85 .
This needs some documentation changes at the least.