Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus agent config file generates empty string for global.evaluation_interval key #1469

Closed
kralicky opened this issue Jun 1, 2023 · 2 comments · Fixed by #1470 or #1472
Closed

Prometheus agent config file generates empty string for global.evaluation_interval key #1469

kralicky opened this issue Jun 1, 2023 · 2 comments · Fixed by #1470 or #1472
Assignees
@kralicky
Labels
bug Something isn't working release-blocker

Comments

@kralicky
Copy link
Member

kralicky commented Jun 1, 2023

(v0.10.0-rc4 regression)
This causes prometheus agents to fail to start with:

ts=2023-06-01T21:11:10.112Z caller=main.go:468 level=error msg="Error loading config (--config.file=/etc/prometheus/config_out/prometheus.env.yaml)" file=/etc/prometheus/config_out/prometheus.env.yaml err="parsing YAML file /etc/prometheus/config_out/prometheus.env.yaml: empty duration string"

The config files in question contain:

global:
  evaluation_interval: ""
  scrape_interval: 30s
...
@kralicky kralicky added bug Something isn't working release-blocker labels Jun 1, 2023
@kralicky kralicky self-assigned this Jun 1, 2023
@kralicky
Copy link
Member Author

kralicky commented Jun 1, 2023

Possibly caused by #1458

@kralicky
Copy link
Member Author

kralicky commented Jun 1, 2023

Root cause may be wrangler not knowing about //+kubebuilder:default comments.

@kralicky kralicky mentioned this issue Jun 1, 2023
Merged
@dbason dbason mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kralicky kralicky

Labels
bug Something isn't working release-blocker
Projects
None yet
Milestone
No milestone
1 participant
@kralicky