Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Provider Azure : add check on mandatory fields #16334

Closed
david-maumenee opened this issue Oct 29, 2018 · 2 comments
Closed

Cloud Provider Azure : add check on mandatory fields #16334

david-maumenee opened this issue Oct 29, 2018 · 2 comments
Assignees
@tfiduccia @loganhz @davidnuzik
Labels
area/azure area/cloud-provider area/cluster kind/enhancement Issues that improve or augment existing functionality
Milestone
v2.2

Comments

@david-maumenee
Copy link

kind : enhancement

Steps to reproduce :

  • Add a cluster on Azure IaaS and select "cloud Provider" Azure
  • Confirm the creation without fill in mandatory fields

Result:
Rancher UI don't display any warning, but the Cluster provisioning stuck in "provisioning"

Environment information

  • Rancher version : v2.1.1

request
Add check on mandatory fields

  • subscription_id
  • tenant_id
  • aad_client_id
  • aad_client_secret
@loganhz loganhz added area/azure area/ui kind/enhancement Issues that improve or augment existing functionality area/cloud-provider labels Oct 29, 2018
@loganhz loganhz self-assigned this Nov 16, 2018
@loganhz loganhz added this to the v2.2 milestone Nov 20, 2018
@loganhz loganhz mentioned this issue Nov 23, 2018
Merged
@davidnuzik
Copy link
Contributor

Note: blocked by #16893 and #16887 (not able to fully test and validate all is working correctly because cannot successfully fully provision azure cloud)

@davidnuzik
Copy link
Contributor

We are able to provision Azure / custom RKE with azure cloud option now.
Version: master 2.2 (12/10/18)
Confirmed fixed. Verified that the form is validated by checking each of the required fields. Tested with both Azure RKE and custom RKE with azure cloud option. This worked in both cases. Confirmed I could stand up a cluster for each. Halo tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfiduccia tfiduccia

@loganhz loganhz

@davidnuzik davidnuzik

Labels
area/azure area/cloud-provider area/cluster kind/enhancement Issues that improve or augment existing functionality
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
5 participants
@westlywright @david-maumenee @tfiduccia @loganhz @davidnuzik