Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: User role selection not taking effect #22260

Closed
deniseschannon opened this issue Aug 18, 2019 · 2 comments
Closed

Backport: User role selection not taking effect #22260

deniseschannon opened this issue Aug 18, 2019 · 2 comments
Assignees
Labels
kind/bug Issues that are defects reported by users or that we know have reached a real release team/ui [zube]: Done
Milestone

Comments

@deniseschannon
Copy link

#19640

@deniseschannon deniseschannon added kind/bug Issues that are defects reported by users or that we know have reached a real release [zube]: To Test team/ui labels Aug 18, 2019
@deniseschannon deniseschannon added this to the v2.2.8 milestone Aug 18, 2019
@deniseschannon
Copy link
Author

Available in UI: 2.2.94

@davidnuzik
Copy link
Contributor

Reproduction:
v2.2.7

  1. Log into Rancher v2.2.7 as admin
  2. Click on Add User. Enter Username, Password. Select global Permissions - Custom.
  3. Select individual permissions by clicking on the text (example: Click on text Create Clusters to select the permission. (Do not click on the checkbox to select)
  4. Clicking on the text, selects the checkbox.
  5. Click on Create.

Expected Result:
Permissions should be set for the user.

Actual Result:
Permissions are not set for the user. Can be tested when you select the user created, and click on Edit User. Permissions which you selected in Step 3, will not be selected for the user.
You can also see there is no POST to /v3/globalrolebinding for the "clusters-create" globalRoleId

Note:
Try creating another user, and this time actually pick the checkbox. The user has the proper "Create Clusters" permission now (the second POST to globalrolebinding included the "clusters-create" globalRoleId
This proves that the issue was a UI issue.

Validation:
v2.2.-head (8/18/19) (a6c23c95) (with ui-index 2.2.94 set)

Execute the same steps as outlined above in the Reproduction section.

Result:
Now permissions are properly set for the user.
We see BOTH of the POSTs to /v3/globalrolebinding go through. The standard one for "user-base" globalRoleId and the second one for "clusters-create" globalRoleId.
When I edit the user I see that "Create Clusters" is checked now.
When I check the API for the user I can confirm it has the "clusters-create" and "user-base" roles. (i.e. query globalRoleBindings with my userId like /v3/globalRoleBindings?userId=u-smqvv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues that are defects reported by users or that we know have reached a real release team/ui [zube]: Done
Projects
None yet
Development

No branches or pull requests

4 participants