Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant edit description on clusters created with rke templates #26754

Closed
aemneina opened this issue Apr 22, 2020 · 3 comments
Closed

cant edit description on clusters created with rke templates #26754

aemneina opened this issue Apr 22, 2020 · 3 comments
Assignees
Labels
internal kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 [zube]: Done
Milestone

Comments

@aemneina
Copy link

What kind of request is this (question/bug/enhancement/feature request):
bug

Steps to reproduce (least amount of steps as possible):

  1. create cluster and select an existing rke template
  2. after cluster is provisioned, edit cluster, modifying description
  3. click save

Result:
the description doesnt get updated or saved. custom clusters work fine, its just when you use rke templates, the description change is omitted.

@aemneina aemneina added kind/bug Issues that are defects reported by users or that we know have reached a real release internal labels Apr 22, 2020
@aemneina
Copy link
Author

UI doesnt seem to preserve annotations added via the UI as well.

@soumyalj
Copy link

soumyalj commented May 20, 2020

  • Reproduced the issue with v2.4.3.
  1. Create a RKE template "template1"
  2. Create a cluster using "template1"
  3. Edit the cluster and add description, labels and annotations and save
    The description/labels/annotation do not get updated.
  • Validated the fix with v2.4-head(8e20687)
  1. Created a RKE template "template1"
  2. Create a cluster using "template1"
  3. Edit the cluster and add description, labels and annotations and save
    The description, labels and annotations are updated correctly.
    Screen Shot 2020-05-19 at 5 57 41 PM

API is updated as below:

"created": "2020-05-20T00:34:50Z",
"createdTS": 1589934890000,
"creatorId": "user-s7z97",
"defaultClusterRoleForProjectMembers": null,
"defaultPodSecurityPolicyTemplateId": null,
"description": "testnew",
"desiredAgentImage": "",
"desiredAuthImage": "",
"dockerRootDir": "/var/lib/docker",
"driver": "rancherKubernetesEngine",
"enableClusterAlerting": false,
"enableClusterMonitoring": false,
"enableNetworkPolicy": false,
"id": "c-vkvjq",
"internal": false,
"istioEnabled": false,
"labels": {
"cattle.io/creator": "norman",
"t1": "v1",
"t2": "v2"
},

"annotations": {
"a1": "a2",
"a3": "a4",
"authz.management.cattle.io/creator-role-bindings": "{\"created\":[\"cluster-owner\"],\"required\":[\"cluster-owner\"]}",
"lifecycle.cattle.io/create.cluster-agent-controller-cleanup": "true",
"lifecycle.cattle.io/create.cluster-provisioner-controller": "true",
"lifecycle.cattle.io/create.cluster-scoped-gc": "true",
"lifecycle.cattle.io/create.mgmt-cluster-rbac-remove": "true",
"provisioner.cattle.io/ke-driver-update": "updated"
},



@soumyalj
Copy link

Validated the fix with master-head build (dea919f)

  1. Create a RKE template "template1"
  2. Create a cluster using "template1"
    Edit the cluster and add description, labels and annotations and save
    The description, labels and annotations are updated correctly.
    API also reflects the description, labels, annotations.
created": "2020-05-21T00:32:57Z",
"createdTS": 1590021177000,
"creatorId": "user-nd9k6",
"defaultClusterRoleForProjectMembers": null,
"defaultPodSecurityPolicyTemplateId": null,
"description": "testdesc",
"desiredAgentImage": null,
"desiredAuthImage": null,
"dockerRootDir": "/var/lib/docker",
"driver": "rancherKubernetesEngine",
"enableClusterAlerting": false,
"enableClusterMonitoring": false,
"enableNetworkPolicy": false,
"id": "c-zpq5b",
"internal": false,
"istioEnabled": false,
"labels": {
"cattle.io/creator": "norman",
"l1": "l2"
},

"annotations": {
"a1": "a2",
"authz.management.cattle.io/creator-role-bindings": "{\"created\":[\"cluster-owner\"],\"required\":[\"cluster-owner\"]}",
"lifecycle.cattle.io/create.cluster-agent-controller-cleanup": "true",
"lifecycle.cattle.io/create.cluster-provisioner-controller": "true",
"lifecycle.cattle.io/create.cluster-scoped-gc": "true",
"lifecycle.cattle.io/create.mgmt-cluster-rbac-remove": "true",
"provisioner.cattle.io/ke-driver-update": "updated"
},


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal kind/bug Issues that are defects reported by users or that we know have reached a real release priority/0 [zube]: Done
Projects
None yet
Development

No branches or pull requests

6 participants