Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cisco ACI (noiro) images exist in rancher-images.txt release artifact #30840

Closed
superseb opened this issue Jan 14, 2021 · 1 comment
Closed

Cisco ACI (noiro) images exist in rancher-images.txt release artifact #30840

superseb opened this issue Jan 14, 2021 · 1 comment
Assignees
@superseb @slickwarren
Labels
kind/bug Issues that are defects reported by users or that we know have reached a real release
Milestone
v2.5.6

Comments

@superseb
Copy link
Contributor

superseb commented Jan 14, 2021 •
edited

Currently, noiro prefixed images (Cisco ACI) exist in rancher-images.txt. As this is not a supported CNI (like Weave), we shouldn't include the images.

$ curl -sL https://github.com/rancher/rancher/releases/download/v2.5.5/rancher-images.txt | grep ^noiro
noiro/aci-containers-controller:5.1.1.0.1ae238a
noiro/aci-containers-host:5.1.1.0.1ae238a
noiro/cnideploy:5.1.1.0.1ae238a
noiro/gbp-server:5.1.1.0.1ae238a
noiro/openvswitch:5.1.1.0.1ae238a
noiro/opflex-server:5.1.1.0.1ae238a
noiro/opflex:5.1.1.0.1ae238a

This also applies to the generated image list when you download it from the UI.
@superseb superseb added the kind/bug Issues that are defects reported by users or that we know have reached a real release label Jan 14, 2021
@superseb superseb added this to the v2.5.6 milestone Jan 14, 2021
@superseb superseb self-assigned this Jan 14, 2021
This was referenced Jan 14, 2021
Merged
Merged
@superseb superseb mentioned this issue Jan 19, 2021
Merged
@superseb superseb mentioned this issue Jan 26, 2021
Merged
@zube zube bot removed the [zube]: Review label Jan 26, 2021
@slickwarren slickwarren mentioned this issue Jan 29, 2021
Closed
@slickwarren
Copy link
Contributor

checked on v2.5.6-rc3, and found no noiro entries in rancher-images.txt

@zube zube bot removed the [zube]: Done label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@superseb superseb

@slickwarren slickwarren

Labels
kind/bug Issues that are defects reported by users or that we know have reached a real release
Projects
None yet
Milestone
v2.5.6
Development

No branches or pull requests
5 participants
@luthermonson @superseb @deniseschannon @slickwarren @sowmyav27