-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows RKE2 Registration Command #33625
Comments
Outstanding PR #33759 |
on master-head (256a0eb) I ran into this issue when running the new windows registration command:
|
I am not able to reproduce this on 2.6rc. Testing now with master-head. |
reopening for the above issue (after offline discussion) |
blocked by #34282 |
blocked #34408 |
We should use this issue to track that the registration command is working as expected. As part of the registration command, we need to verify that the labels are added to the kube nodes and machines. The machine label selector was specifically tested with #33904 and no need to test separately. |
Verified on v2.6-head 2e55e84 labels |
We need to
--label cattle.io/os=windows
for windows--label cattle.io/os=linux
for linuxduring testing confirm that machine label selectors work for config and try to set kubelet-args etc. and see if the config propagates to the downstream node. if it doesn't work figure out why and create a new issue for it.
The text was updated successfully, but these errors were encountered: