Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated setting kubeconfig-token-ttl-minutes #38535

Closed
KevinJoiner opened this issue Aug 5, 2022 · 11 comments
Closed

Remove Deprecated setting kubeconfig-token-ttl-minutes #38535

KevinJoiner opened this issue Aug 5, 2022 · 11 comments
Assignees
Labels
kind/enhancement Issues that improve or augment existing functionality QA/S release-note Note this issue in the milestone's release notes status/release-note-added team/area1
Milestone

Comments

@KevinJoiner
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@KevinJoiner KevinJoiner added the kind/enhancement Issues that improve or augment existing functionality label Aug 5, 2022
@samjustus samjustus added this to the v2.x - Backlog milestone Aug 5, 2022
@samjustus
Copy link
Collaborator

@Jono-SUSE-Rancher can you make a 2.8 milestone please?

@Jono-SUSE-Rancher
Copy link
Contributor

@Jono-SUSE-Rancher can you make a 2.8 milestone please?

I don't understand your request, but by golly I'm in.

@KevinJoiner
Copy link
Contributor Author

@Jono-SUSE-Rancher We are deprecating kubeconfig-token-ttl-minutes in this next release. This issue is to officially remove the setting in 2.8.0

@KevinJoiner
Copy link
Contributor Author

This will also need a docs page update for 2.8

@JonCrowther JonCrowther added the release-note Note this issue in the milestone's release notes label Aug 28, 2023
@JonCrowther
Copy link
Contributor

Validation

Root Cause

The setting kubeconfig-token-ttl-minutes was set to be deprecated for 2.8.

What was fixed, or what change has occurred

The kubeconfig-token-ttl-minutes setting has been removed. It can no longer be found in the Global Settings, and can't be set via command line option when building rancher. It has been replaced by the setting kubeconfig-default-token-ttl-minutes.

Areas or cases that should be tested

Create a rancher instance and see that the kubeconfig-token-ttl-minutes option is not present in the global settings.

What areas could experience regressions

Possibly any tests revolving around kubeconfig tokens may break if they're checking a different value.

Are the repro steps accurate/minimal?

Yes

@gaktive
Copy link
Member

gaktive commented Oct 3, 2023

As @JonCrowther indicated, there is UI impact here which is hitting late for 2.8.0. We'll assess how quickly this can be done but earlier warning about dashboard changes would be helpful going forward so we're not scrambling at the end.

@anupama2501
Copy link
Contributor

anupama2501 commented Oct 5, 2023

Re opening for a few more validations.

@JonCrowther
Copy link
Contributor

Release note

Synopsis of issue

The setting kubeconfig-token-ttl-minutes has been deprecated.

Resolution

The setting has been removed. For more info visit: https://ranchermanager.docs.rancher.com/v2.5/reference-guides/about-the-api/api-tokens#setting-ttl-on-kubeconfig-tokens

@anupama2501
Copy link
Contributor

Verified on an upgrade from v2.7.8 >> v2.8-head 01127d8

@JonCrowther This is not listed in the UI anymore but I still see this listed at /v3/settings/kubeconfig-token-ttl-minutes and /v1/management.cattle.io.settings

@anupama2501
Copy link
Contributor

from offline conversation:

For 38535, I opened a dashboard ticket, but even if that gets fixed, the setting will be visible in v3/settings, but doesn't do anything. There isn't any method of cleaning up settings on an upgrade. If that's something we want to pursue it would be feature work for a future milestone

Created the linked ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues that improve or augment existing functionality QA/S release-note Note this issue in the milestone's release notes status/release-note-added team/area1
Projects
None yet
Development

No branches or pull requests

8 participants