Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatekeeper-CRD chart apiVersion is still v1. Need to update it to v2 #41557

Closed
rayandas opened this issue May 15, 2023 · 1 comment
Closed

Gatekeeper-CRD chart apiVersion is still v1. Need to update it to v2 #41557

rayandas opened this issue May 15, 2023 · 1 comment
Labels
area/charts kind/enhancement Issues that improve or augment existing functionality status/stale team/area3 team/mapps

Comments

@rayandas
Copy link
Contributor

Currently rancher-gatekeeper-crd chart apiversion is v1 (https://github.com/rancher/charts/blob/a8dda01c8c939286f30a0539f00acf83be21663b/charts/rancher-gatekeeper-crd/102.1.0%2Bup3.12.0/Chart.yaml#L6).

It needs to be updated to v2 in order to add Hull tests for it. Else Hull tests will fail showing the below error.

    --- FAIL: TestChart/Set_.Values.global.cattle.systemDefaultRegistry (0.03s)
        --- FAIL: TestChart/Set_.Values.global.cattle.systemDefaultRegistry/HelmLint (0.02s)
            template.go:171: [INFO] Chart.yaml: icon is recommended
            template.go:192: 1 error occurred:
                        * [ERROR] Chart.yaml: chart type is not valid in apiVersion 'v1'. It is valid in apiVersion 'v2'

The PR for gatekeeper-crd Hull test: rancher/charts#2625

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/charts kind/enhancement Issues that improve or augment existing functionality status/stale team/area3 team/mapps
Projects
None yet
Development

No branches or pull requests

2 participants