Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove clusterauthtokens in the controller's handler when the corresponding orphaned clusteruserattribute is deleted #45015

Closed
pmatseykanets opened this issue Apr 3, 2024 · 1 comment
Closed

[BUG] Remove clusterauthtokens in the controller's handler when the corresponding orphaned clusteruserattribute is deleted #45015

pmatseykanets opened this issue Apr 3, 2024 · 1 comment
Assignees
@pmatseykanets @joesims22
Labels
area/rbac kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 team/collie the team that is responsible for auth and rbac within rancher
Milestone
v2.9.0

Comments

@pmatseykanets
Copy link
Contributor

This is continuation of #44914
@pmatseykanets pmatseykanets added kind/bug Issues that are defects reported by users or that we know have reached a real release area/rbac team/collie the team that is responsible for auth and rbac within rancher labels Apr 3, 2024
@pmatseykanets pmatseykanets self-assigned this Apr 3, 2024
@pmatseykanets pmatseykanets added this to the v2.9-Next1 milestone Apr 3, 2024
@pmatseykanets
Copy link
Contributor Author

pmatseykanets commented May 7, 2024 •
edited
Loading

It seems like we don't need to implement a special clean up for clusterauthtokens after all because if the token's user reference is changed in the local cluster the corresponding clusterauthtoken will be updated to reflect the change by the token controller

rancher/pkg/controllers/managementuser/clusterauthtoken/token.go

Line 95 in ec76f71

func (h *tokenHandler) Updated(token *managementv3.Token) (runtime.Object, error) {

Unless there are other realistic ways to orphan clusterauthtokens we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmatseykanets pmatseykanets

@joesims22 joesims22

Labels
area/rbac kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 team/collie the team that is responsible for auth and rbac within rancher
Projects
None yet
Milestone
v2.9.0
Development

No branches or pull requests
3 participants
@pmatseykanets @samjustus @joesims22