Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill Tests for APIServer #45244

Open
MbolotSuse opened this issue Apr 25, 2024 · 0 comments
Open

Backfill Tests for APIServer #45244

MbolotSuse opened this issue Apr 25, 2024 · 0 comments
Labels
priority/0 QA/None Indicates that the task or issue does not need QA. team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Milestone

Comments

@MbolotSuse
Copy link
Contributor

APIServer currently has limited tests, and the tests that it does have are focused mostly on unit test functionality. This creates a need for highly manual review of things like dependency bumps, and low confidence in the regression potential for changes. These tests should focus on how APIServer would be used as a library and avoid mocking as much as is possible. Some potential examples:

  • Create an APIServer. Register a new type.
    • Register a path for the resource using the same "gorrilla/mux" version as the rest of APIServer.
    • Make sure that without resource/collection methods, this isn't accessible to the outside world.
    • Create/update/delete the new type (after adding http verbs to allow access)
  • Use APIroot to register more than one collection of schemas, and ensure that the resources of each collection are accessible
  • Use Subscribe to add a websocket for the schemas. Ensure create/update/delete events are streamed.
  • Use an "AccessControl" struct to allow access to different types of requests (for example, based on userID). Ensure that requests are allowed/rejected as expected.
@MbolotSuse MbolotSuse added priority/0 QA/None Indicates that the task or issue does not need QA. team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas labels Apr 25, 2024
@MbolotSuse MbolotSuse added this to the v2.9-Next2 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/0 QA/None Indicates that the task or issue does not need QA. team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Projects
None yet
Development

No branches or pull requests

1 participant