Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate go mod bumps result in go get -d -t ./... failures #272

Open
thardeck opened this issue Apr 25, 2024 · 2 comments
Open

Renovate go mod bumps result in go get -d -t ./... failures #272

thardeck opened this issue Apr 25, 2024 · 2 comments

Comments

@thardeck
Copy link

We had at least two go mod bump prs by renovate where renovate itself realized that there was an issue but still created them.

rancher/fleet#2304

Command failed: go get -d -t ./...
go: github.com/imdario/mergo@v1.0.0: parsing go.mod:
	module declares its path as: dario.cat/mergo
	        but was required as: github.com/imdario/mergo

rancher/fleet#2305

Command failed: go get -d -t ./...
go: gopkg.in/go-playground/webhooks.v6@v6.3.0: parsing go.mod:
	module declares its path as: github.com/go-playground/webhooks/v6
	        but was required as: gopkg.in/go-playground/webhooks.v6

@pjbgf
Copy link
Member

pjbgf commented Apr 25, 2024

This is a very specific issue: a dependency changing its module name. IMO these cases are best handled manually.

Now the question is, should a PR be created for this or not? Given that this is configurable via prCreation, I think each team can use whatever option it works best for them. So to avoid noise from failing PRs a team can change their .github/renovate.json to contain: "prCreation": "status-success".

But by default, I think we should continue to open those PRs so at least teams know that there is a dependency to be updated and it contains breaking changes, however they will need to manually create a superseding PR for it.

@thardeck
Copy link
Author

@pjbgf just for the records I have another example:
rancher/fleet#2447

Command failed: go get -d -t ./...
go: downloading sigs.k8s.io/controller-tools v0.15.0
go: downloading k8s.io/client-go v0.30.1
[...]
go: downloading sigs.k8s.io/kustomize/kyaml v0.17.1
go: downloading sigs.k8s.io/kustomize v2.0.3+incompatible
go: github.com/rancher/fleet/internal/cmd/controller/imagescan/update imports
	sigs.k8s.io/kustomize/kyaml/setters2: cannot find module providing package sigs.k8s.io/kustomize/kyaml/setters2
go: github.com/rancher/fleet/cmd/codegen imports
	github.com/rancher/wrangler/v2/pkg/controller-gen/args imports
	k8s.io/code-generator/cmd/client-gen/path: cannot find module providing package k8s.io/code-generator/cmd/client-gen/path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants