Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade option should allow for upgrading services when configurations (other than image) is updated. #43

Closed
sangeethah opened this issue Nov 23, 2017 · 3 comments
Assignees
Milestone

Comments

@sangeethah
Copy link

rke version v0.0.4-dev

Currently upgrade option allows for upgrading services only when image name provided in cluster yml file is different from what is being deployed in the cluster. We should allow for upgrading services when configurations (other than image) is updated.

@HighwayofLife
Copy link
Contributor

This is still an issue, if arguments or attributes are added to a service, the service will not restart and thus not apply those changes to attributes. We need a way to determine if a service should be restarted with the updates made to a cluster.yml file, or when comparing the ideal state with the current state of that particular service.

@HighwayofLife
Copy link
Contributor

@galal-hussein was this solved/fixed in 36e37d5 ?

@deniseschannon deniseschannon added this to the v0.1.9 milestone Jun 25, 2018
@moelsayed
Copy link
Contributor

This has been already implemented. All services support upgrades when any configuration parameter is changed.

@deniseschannon deniseschannon modified the milestones: v0.1.9, v0.1.8 Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants