Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes should stop when stopping rke2 process on windows agent #1755

Closed
rancher-max opened this issue Sep 3, 2021 · 7 comments
Closed
Assignees
Labels
area/windows kind/bug Something isn't working

Comments

@rancher-max
Copy link
Contributor

Environmental Info:
RKE2 Version:

v1.21.4-rc1+rke2r3

Node(s) CPU architecture, OS, and Version:

Windows 2019

Cluster Configuration:

1 server 1 windows agent

Describe the bug:

When running the rke2 agent as a service, and then performing Stop-Process rke2, I expect the kubelet, kube-proxy, and containerd processes to also stop, similar as when stopping the rke2 binary process.

Steps To Reproduce:

  • Install rke2 on windows node
  • Run the rke2 agent as a service
  • Stop the rke2 process

Expected behavior:

rke2, kubelet, kube-proxy, and containerd processes should all stop

Actual behavior:

Only rke2 process is stopped

Additional context / logs:

@rancher-max
Copy link
Contributor Author

When validating this, we should also bring up linux servers/agents and validate the running killall, uninstall, and cluster-reset all continue to function properly

@brandond
Copy link
Contributor

brandond commented Nov 4, 2021

As well as just basic service start/stop/restart behavior.

@rancher-max
Copy link
Contributor Author

This issue mentions the last step as: Stop-Process rke2, but this is actually not the correct behavior. In this case, we should do Stop-Service rke2 (stopping the SERVICE, not the PROCESS), as this is what most Windows Admins will do anyway.

@mdrahman-suse mdrahman-suse moved this from To Test to Waiting for RC in Development [DEPRECATED] Nov 22, 2021
@mdrahman-suse
Copy link
Contributor

Tested rke2 using v1.21.6-rc2+rke2r2 and I am not seeing any other services (kube-proxy, kubelet, containerd, etc) other than rke2 getting stopped when I perform Stop-Service rke2. Please advice @luthermonson @rosskirkpat
CC: @rancher-max

@nickgerace
Copy link

Fleet v0.3.8-rc2 (now on Rancher v2.6-head) contains the Wrangler module bump needed for this issue: rancher/fleet#615

@mdrahman-suse
Copy link
Contributor

After debugging with @luthermonson, we came to conclusion that there are some additional code changes requires for this to fully work and it is working better than before and satisfies the scope of this issue. New issue will be raised and tracked for the additional work. At the time of testing this ticket it was observed that Stop-Service rke2 stops most of the services used by rke2, except for one or two like kubelet and kube-proxy. For now they are stopped manually via Stop-Process -Name <service>

@mdrahman-suse
Copy link
Contributor

Verified on rke2 RCs v1.21.7-rc3+rke2r1 and v1.22.4-rc2+rke2r1 following the same steps. Also raised #2204 to track the additional work needed.
CC: @luthermonson @rancher-max

Development [DEPRECATED] automation moved this from Waiting for RC to Done Issue / Merged PR Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows kind/bug Something isn't working
Projects
No open projects
Development [DEPRECATED]
Done Issue / Merged PR
Development

No branches or pull requests

5 participants