Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility support for RKE1 labels #653

Closed
tomerleib opened this issue Jan 7, 2021 · 4 comments
Closed

Backwards compatibility support for RKE1 labels #653

tomerleib opened this issue Jan 7, 2021 · 4 comments

Comments

@tomerleib
Copy link

RKE1 assigns the label node-role.kubernetes.io/controlplane to controlplane server, this allows master servers to work with service ELB.
RKE2 is using the node-role.kubernetes.io/master on the controlplane nodes and blocks service ELB from using those servers.

For future upgrade from RKE1 to RKE2, the labels should be persistent, otherwise it will break the compatibility with current installations.

@stale
Copy link

stale bot commented Aug 2, 2021

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 180 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Aug 2, 2021
@immanuelfodor
Copy link

Unstale

@stale stale bot removed the status/stale label Aug 3, 2021
@brandond
Copy link
Contributor

brandond commented Aug 3, 2021

controlplane is incorrect; upstream uses control-plane which is what we will continue to do. The master role is being deprecated and will be dropped soon.

@stale
Copy link

stale bot commented Jan 30, 2022

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 180 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@stale stale bot added the status/stale label Jan 30, 2022
@stale stale bot closed this as completed Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants