Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hetzner] rancher2_node_template ignores "networks" #656

Closed
Jasstkn opened this issue May 10, 2021 · 3 comments
Closed

[hetzner] rancher2_node_template ignores "networks" #656

Jasstkn opened this issue May 10, 2021 · 3 comments

Comments

@Jasstkn
Copy link

Jasstkn commented May 10, 2021

Hi!

I've noticed that if I pass "networks" as string value to rancher2_node_template, it's ignored.

I'm not sure but maybe problem is in the mismatch of types here([]string) and here(string)

@rawmind0
Copy link
Contributor

I'm not sure but maybe problem is in the mismatch of types here([]string) and here(string)

This shouldn't be an issue, it's properly adapted in the expander and the flatten

cc: @alexzimmer96

@rawmind0
Copy link
Contributor

The issue seems to be at hetzner docker machine driver. networks field is not set as "public" at golang struct, https://github.com/JonasProgrammer/docker-machine-driver-hetzner/blob/master/driver.go#L42, so json marshal/unmarshall is just ignoring it.

@alexzimmer96 , could you please take a look on this??

@process0
Copy link

@Jasstkn I've tried to reproduce this but I cannot. I believe JonasProgrammer/docker-machine-driver-hetzner#64 has solved this.

@Jasstkn Jasstkn closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants