-
Notifications
You must be signed in to change notification settings - Fork 59
/
validator.go
254 lines (223 loc) · 10.3 KB
/
validator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
// Package projectroletemplatebinding is used for validating ProjectRoleTemplateBinding admission requests.
package projectroletemplatebinding
import (
"errors"
"fmt"
"strings"
apisv3 "github.com/rancher/rancher/pkg/apis/management.cattle.io/v3"
"github.com/rancher/webhook/pkg/admission"
"github.com/rancher/webhook/pkg/auth"
v3 "github.com/rancher/webhook/pkg/generated/controllers/management.cattle.io/v3"
objectsv3 "github.com/rancher/webhook/pkg/generated/objects/management.cattle.io/v3"
"github.com/rancher/webhook/pkg/resolvers"
admissionv1 "k8s.io/api/admission/v1"
admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/validation/field"
k8validation "k8s.io/kubernetes/pkg/registry/rbac/validation"
"k8s.io/utils/trace"
)
var gvr = schema.GroupVersionResource{
Group: "management.cattle.io",
Version: "v3",
Resource: "projectroletemplatebindings",
}
// NewValidator returns a new validator used for validation PRTB.
func NewValidator(prtb *resolvers.PRTBRuleResolver, crtb *resolvers.CRTBRuleResolver,
defaultResolver k8validation.AuthorizationRuleResolver, roleTemplateResolver *auth.RoleTemplateResolver,
clusterCache v3.ClusterCache, projectCache v3.ProjectCache) *Validator {
clusterResolver := resolvers.NewAggregateRuleResolver(defaultResolver, crtb)
projectResolver := resolvers.NewAggregateRuleResolver(defaultResolver, prtb)
return &Validator{
admitter: admitter{
clusterResolver: clusterResolver,
projectResolver: projectResolver,
roleTemplateResolver: roleTemplateResolver,
clusterCache: clusterCache,
projectCache: projectCache,
},
}
}
// Validator validates PRTB admission request.
type Validator struct {
admitter admitter
}
// GVR returns the GroupVersionKind for this CRD.
func (v *Validator) GVR() schema.GroupVersionResource {
return gvr
}
// Operations returns list of operations handled by this validator.
func (v *Validator) Operations() []admissionregistrationv1.OperationType {
return []admissionregistrationv1.OperationType{admissionregistrationv1.Update, admissionregistrationv1.Create}
}
// ValidatingWebhook returns the ValidatingWebhook used for this CRD.
func (v *Validator) ValidatingWebhook(clientConfig admissionregistrationv1.WebhookClientConfig) []admissionregistrationv1.ValidatingWebhook {
return []admissionregistrationv1.ValidatingWebhook{*admission.NewDefaultValidatingWebhook(v, clientConfig, admissionregistrationv1.NamespacedScope, v.Operations())}
}
// Admitters returns the admitter objects used to validate ProjectRoleTemplateBindings.
func (v *Validator) Admitters() []admission.Admitter {
return []admission.Admitter{&v.admitter}
}
type admitter struct {
clusterResolver k8validation.AuthorizationRuleResolver
projectResolver k8validation.AuthorizationRuleResolver
roleTemplateResolver *auth.RoleTemplateResolver
clusterCache v3.ClusterCache
projectCache v3.ProjectCache
}
// Admit is the entrypoint for the validator. Admit will return an error if it's unable to process the request.
// If this method is called on a nil Validator, it panics.
func (a *admitter) Admit(request *admission.Request) (*admissionv1.AdmissionResponse, error) {
listTrace := trace.New("projectRoleTemplateBindingValidator Admit", trace.Field{Key: "user", Value: request.UserInfo.Username})
defer listTrace.LogIfLong(admission.SlowTraceDuration)
fieldPath := field.NewPath("projectroletemplatebinding")
if request.Operation == admissionv1.Update {
oldPRTB, newPRTB, err := objectsv3.ProjectRoleTemplateBindingOldAndNewFromRequest(&request.AdmissionRequest)
if err != nil {
return nil, fmt.Errorf("failed to decode old and new PRTB objects from request: %w", err)
}
if err := validateUpdateFields(oldPRTB, newPRTB, fieldPath); err != nil {
return admission.ResponseBadRequest(err.Error()), nil
}
}
prtb, err := objectsv3.ProjectRoleTemplateBindingFromRequest(&request.AdmissionRequest)
if err != nil {
return nil, fmt.Errorf("failed to decode PRTB object from request: %w", err)
}
if request.Operation == admissionv1.Create {
var fieldErr *field.Error
if err := a.validateCreateFields(prtb, fieldPath); err != nil {
if errors.As(err, &fieldErr) {
return admission.ResponseBadRequest(err.Error()), nil
}
return nil, fmt.Errorf("failed to validate fields on create: %w", err)
}
}
roleTemplate, err := a.roleTemplateResolver.RoleTemplateCache().Get(prtb.RoleTemplateName)
if err != nil {
if apierrors.IsNotFound(err) {
return &admissionv1.AdmissionResponse{
Allowed: true,
}, nil
}
return nil, fmt.Errorf("failed to get referenced roleTemplate '%s' for PRTB: %w", roleTemplate.Name, err)
}
rules, err := a.roleTemplateResolver.RulesFromTemplate(roleTemplate)
if err != nil {
return nil, fmt.Errorf("failed to get rules from referenced roleTemplate '%s': %w", roleTemplate.Name, err)
}
clusterNS, projectNS := clusterAndProjectID(prtb.ProjectName)
err = auth.ConfirmNoEscalation(request, rules, clusterNS, a.clusterResolver)
if err == nil {
return &admissionv1.AdmissionResponse{Allowed: true}, nil
}
response := &admissionv1.AdmissionResponse{}
auth.SetEscalationResponse(response, auth.ConfirmNoEscalation(request, rules, projectNS, a.projectResolver))
return response, nil
}
func clusterAndProjectID(projectName string) (string, string) {
pieces := strings.Split(projectName, ":")
if len(pieces) < 2 {
return "", ""
}
return pieces[0], pieces[1]
}
// validUpdateFields checks if the fields being changed are valid update fields.
func validateUpdateFields(oldPRTB, newPRTB *apisv3.ProjectRoleTemplateBinding, fieldPath *field.Path) *field.Error {
const reason = "field is immutable"
switch {
case oldPRTB.RoleTemplateName != newPRTB.RoleTemplateName:
return field.Invalid(fieldPath.Child("roleTemplateName"), newPRTB.RoleTemplateName, reason)
case oldPRTB.ProjectName != newPRTB.ProjectName:
return field.Invalid(fieldPath.Child("projectName"), newPRTB.ProjectName, reason)
case oldPRTB.UserName != newPRTB.UserName && oldPRTB.UserName != "":
return field.Invalid(fieldPath.Child("userName"), newPRTB.UserName, reason)
case oldPRTB.UserPrincipalName != newPRTB.UserPrincipalName && oldPRTB.UserPrincipalName != "":
return field.Invalid(fieldPath.Child("userPrincipalName"), newPRTB.UserPrincipalName, reason)
case oldPRTB.GroupName != newPRTB.GroupName && oldPRTB.GroupName != "":
return field.Invalid(fieldPath.Child("groupName"), newPRTB.GroupName, reason)
case oldPRTB.GroupPrincipalName != newPRTB.GroupPrincipalName && oldPRTB.GroupPrincipalName != "":
return field.Invalid(fieldPath.Child("groupPrincipalName"), newPRTB.GroupPrincipalName, reason)
case (newPRTB.GroupName != "" || oldPRTB.GroupPrincipalName != "") && (newPRTB.UserName != "" || oldPRTB.UserPrincipalName != ""):
return field.Forbidden(fieldPath,
"binding must target either a user [userName]/[userPrincipalName] OR a group [groupName]/[groupPrincipalName]")
case oldPRTB.ServiceAccount != newPRTB.ServiceAccount:
return field.Forbidden(fieldPath.Child("serviceAccount"), "update is not allowed")
default:
return nil
}
}
// validateCreateFields checks if all required fields are present and valid.
func (a *admitter) validateCreateFields(newPRTB *apisv3.ProjectRoleTemplateBinding, fieldPath *field.Path) error {
hasUserTarget := newPRTB.UserName != "" || newPRTB.UserPrincipalName != ""
hasGroupTarget := newPRTB.GroupName != "" || newPRTB.GroupPrincipalName != ""
hasServiceAccountTarget := newPRTB.ServiceAccount != ""
if !onlyOneTrue(hasUserTarget, hasGroupTarget, hasServiceAccountTarget) {
return field.Forbidden(fieldPath,
"binding must target only a user [userName]/[userPrincipalName] OR a group [groupName]/[groupPrincipalName] OR a [serviceAccount]")
}
if newPRTB.ProjectName == "" {
return field.Required(fieldPath.Child("projectName"), "")
}
if newPRTB.RoleTemplateName == "" {
return field.Required(fieldPath.Child("roleTemplateName"), "")
}
roleTemplate, err := a.roleTemplateResolver.RoleTemplateCache().Get(newPRTB.RoleTemplateName)
if err != nil {
return err
}
if roleTemplate.Locked {
return field.Forbidden(fieldPath.Child("roleTemplate"), fmt.Sprintf("referenced role '%s' is locked and cannot be assigned", roleTemplate.DisplayName))
}
const projectContext = "project"
if roleTemplate.Context != projectContext {
return field.NotSupported(fieldPath.Child("roleTemplate", "context"), roleTemplate.Context, []string{projectContext})
}
if newPRTB.ProjectName == "" {
return field.Required(fieldPath.Child("projectName"), "projectName is required")
}
clusterName, projectName := clusterAndProjectID(newPRTB.ProjectName)
if clusterName == "" || projectName == "" {
return field.Invalid(fieldPath.Child("projectName"), newPRTB.ProjectName, "projectName must be of the form cluster.metadata.name:project.metadata.name, and both must refer to an existing object")
}
if projectName != newPRTB.Namespace {
return field.Forbidden(fieldPath, "namespace and the projectName part of projectName must match")
}
cluster, err := a.clusterCache.Get(clusterName)
clusterNotFoundErr := field.Invalid(fieldPath.Child("projectName"), newPRTB.ProjectName, fmt.Sprintf("specified cluster %s not found", clusterName))
if err != nil {
if apierrors.IsNotFound(err) {
return clusterNotFoundErr
}
return fmt.Errorf("unable to verify cluster %s exists: %w", clusterName, err)
}
if cluster == nil {
return clusterNotFoundErr
}
project, err := a.projectCache.Get(clusterName, projectName)
projectNotFoundErr := field.Invalid(fieldPath.Child("projectName"), newPRTB.ProjectName, fmt.Sprintf("specified project %s not found in %s", projectName, clusterName))
if err != nil {
if apierrors.IsNotFound(err) {
return projectNotFoundErr
}
return fmt.Errorf("unable to verify project %s exists for cluster %s: %w", projectName, clusterName, err)
}
if project == nil {
return projectNotFoundErr
}
if project.Spec.ClusterName != clusterName {
reason := fmt.Sprintf("project %s is for cluster %s, prtb specified cluster %s", projectName, project.Spec.ClusterName, clusterName)
return field.Invalid(fieldPath.Child("projectName"), newPRTB.ProjectName, reason)
}
return nil
}
func onlyOneTrue(values ...bool) bool {
var trueCount int
for _, v := range values {
if v {
trueCount++
}
}
return trueCount == 1
}