Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-upgrade functionality to wins to tie into the system-upgrade-controller #181

Closed
rosskirkpat opened this issue May 6, 2022 · 4 comments
Assignees
Milestone

Comments

@rosskirkpat
Copy link
Contributor

rosskirkpat commented May 6, 2022

#104 (comment)
#130 (comment)

The wins agent for RKE2 Windows nodes does not support auto-upgrades at this time. this will be fixed for Rancher v2.6.6

@phillipsj
Copy link
Contributor

@rosskirkpat is there a ticket for the wins and system agent changes that you are doing that we can link here?

@jameson-mcghee
Copy link

Hey, can I get a QA Template for this to help me understand how to test it? Thanks guys
cc @phillipsj

@phillipsj
Copy link
Contributor

Problem

The system-upgrade-controller didn't support Windows.

Solution

To address that issue, the wins upgrader was used to create an image that will work for System Upgrade Controller.

Testing

  1. To test this, you will need to install a previous version of Rancher with an RKE2 cluster with a Windows Node.
  2. Check the wins version installed on the Windows Node
  3. Upgrade Rancher forcing the new system agent, which should trigger wins being upgraded.
  4. Check the wins version after the system upgrade controller executes.

Engineering Testing

Manual Testing

This was manually tested by creating an upgrade image, then manually executing the upgrade job.

Automated Testing

QA Testing Considerations

This will best be accomplished by installing 2.6.6, then upgrade to a 2.6.7 RC or HEAD, then watching the system upgrade controller job execute.

Regressions Considerations

@jameson-mcghee
Copy link

jameson-mcghee commented Jul 28, 2022

During testing I setup a Rancher server on v2.6.6, created a downstream RKE2 Custom cluster with a Windows Worker, and checked the wins version and script for that worker by hitting these API endpoints:

/v3/setting/wins-agent-version
/v3/setting/wins-agent-install-script

On v2.6.6, the wins version was v0.2.10. I also observed that the wins-agent-install-script value was "https://raw.githubusercontent.com/rancher/wins/v0.2.10/install.ps1". I then proceeded to upgrade Rancher to v2.6.7-rc5, and I observed that the wins version was now v0.4.4 and the new wins-agent-install-script value was "https://raw.githubusercontent.com/rancher/wins/v0.4.4/install.ps1".
This clearly indicated to me that the version and script had been automatically updated during the upgrade process (as designed). Therefore I am setting the state of this ticket to Done.

v2.6.6:
image.png
image.png

v2.6.7-rc5:
image.png
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests