Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DualMap support #16

Merged
merged 1 commit into from Mar 9, 2021
Merged

Add DualMap support #16

merged 1 commit into from Mar 9, 2021

Conversation

a-slice-of-py
Copy link
Contributor

Streamlit-folium component now supports also DualMap from Folium plugins.

  • Add switch in streamlit-folium __init__.py to properly handle DualMap rendering

  • Update app example adding DualMap

* Add switch in streamlit-folium __init__ to properly handle DualMap rendering

* Update app example adding DualMap
@randyzwitch
Copy link
Owner

Thanks for submitting this! The tests fail because the app changed, which is expected. I'll review this locally, clean up the test suite and then merge it in if everything looks good

@a-slice-of-py
Copy link
Contributor Author

Thanks for submitting this! The tests fail because the app changed, which is expected. I'll review this locally, clean up the test suite and then merge it in if everything looks good

Yep, sorry but I forgot to check tests and align them accordingly.

I was looking for an elegant way to switch between map types in the example, so I went for modifying existing one. Probably, the new feature should have been shown in a separate file to prevent tests fail.

@randyzwitch
Copy link
Owner

It's no problem at all, the same file is great :)

@randyzwitch
Copy link
Owner

Works locally, going to merge this, then fix the tests in a different commit

@randyzwitch randyzwitch merged commit 0f92d5a into randyzwitch:master Mar 9, 2021
@a-slice-of-py
Copy link
Contributor Author

I checked app on Streamlit sharing and unfortunately dual map page results broken with AttributeError: module 'folium' has no attribute 'plugins' - despite also in my local env everything was fine.

Not sure, but maybe we can fix it with an explicit from folium import plugins and change accordingly line 25 in streamlit_app.py.

@randyzwitch
Copy link
Owner

Thanks strange, thanks for surfacing. I'll fix this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants