Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate support #19

Open
bjesus opened this issue May 26, 2022 · 7 comments
Open

Certificate support #19

bjesus opened this issue May 26, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@bjesus
Copy link

bjesus commented May 26, 2022

Going to a Gemini website that requires a certificate (e.g. gemini://feeds.drewdevault.com) currently just shows "Error: A certificate is required to access this page".

Is there a way to provide a certificate?

@ranfdev
Copy link
Owner

ranfdev commented May 27, 2022

Is there a way to provide a certificate?

Currently? No.

But I'm going to add it

@bjesus
Copy link
Author

bjesus commented May 27, 2022

Ah okay! The error message made me think like I'm misunderstanding how to set the certificate. Glad to hear it will be added!

@ranfdev ranfdev added the enhancement New feature or request label Jun 2, 2022
@Gaming4LifeDE
Copy link

Is there a rough timeframe for this?

I'm currently implementing a gemini client library in python, Do you want the code if i can make it work with certs? Maybe it helps you.

@Gaming4LifeDE
Copy link

Made it work in my python library... basically:

context: ssl.SSLContext = ssl.create_default_context()
    context.check_hostname = False

    def get(self, url: str, cert: str = None, key: str = None, verify_certs: bool = True) -> GeminiResponse:
        if cert is not None and key is not None:
            self.context.load_cert_chain(cert, key)

Try to find if there's anything similar in rust: https://docs.python.org/3/library/ssl.html#ssl.create_default_context

@ranfdev
Copy link
Owner

ranfdev commented Jun 9, 2022

The biggest problem I have right now is not technical, it's that I don't have enough time to do everything.

@LSeelig
Copy link

LSeelig commented Apr 28, 2024

Would you consider contributions? I only ask because I'm not very experienced with networks, but I could try to contribute.

@ranfdev
Copy link
Owner

ranfdev commented Apr 28, 2024

If anyone can provide a working implementation, I will gladly accept it and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants